Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for SwiftShims in SDK #23287

Merged
merged 2 commits into from Mar 15, 2019

Conversation

Projects
None yet
2 participants
@brentdax
Copy link
Collaborator

brentdax commented Mar 14, 2019

…but only if the compiler resource directory doesn’t have them. These will move to the SDK soon.

Resolves rdar://problem/48865477.

Brent Royal-Gordon
Search for SwiftShims in SDK
…but only if the compiler resource directory doesn’t have them. These will move to the SDK soon.

@brentdax brentdax requested review from Rostepher and jrose-apple Mar 14, 2019

@brentdax

This comment has been minimized.

Copy link
Collaborator Author

brentdax commented Mar 14, 2019

My local testing of this is going very strangely in a way that doesn't look like it could be related to this change; I need to head home, so I'll see if it reproduces on CI.

@brentdax

This comment has been minimized.

Copy link
Collaborator Author

brentdax commented Mar 14, 2019

@swift-ci please clean smoke test

@brentdax

This comment has been minimized.

Copy link
Collaborator Author

brentdax commented Mar 14, 2019

@swift-ci smoke test

@brentdax

This comment has been minimized.

Copy link
Collaborator Author

brentdax commented Mar 14, 2019

Local testing looks good after a clean rebuild.

@brentdax brentdax merged commit 450aba7 into apple:master Mar 15, 2019

2 checks passed

Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform (smoke test)
Details

brentdax added a commit to brentdax/swift that referenced this pull request Mar 15, 2019

Search for SwiftShims in SDK (apple#23287)
…but only if the compiler resource directory doesn’t have them. These will move to the SDK soon.

brentdax added a commit that referenced this pull request Mar 15, 2019

Search for SwiftShims in SDK (#23287) (#23317)
…but only if the compiler resource directory doesn’t have them. These will move to the SDK soon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.