Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TF] Update TensorFlowRuntime tests #23367

Merged
merged 1 commit into from Mar 18, 2019

Conversation

@xeno-by
Copy link

commented Mar 17, 2019

Change all import TensorFlowUnittest imports to conditional
import TensorFlowUnittestTPU / import TensorFlowUnittest imports.

Also, update raw_ops.swift to say @inlinable instead of
@_inlineable.

Change all `import TensorFlowUnittest` imports to conditional
`import TensorFlowUnittestTPU` / `import TensorFlowUnittest` imports.

Also, update raw_ops.swift to say `@inlinable` instead of
`@_inlineable`.
@xeno-by xeno-by added the tensorflow label Mar 17, 2019
@xeno-by xeno-by requested a review from marcrasi Mar 17, 2019
@xeno-by

This comment has been minimized.

Copy link
Author

commented Mar 17, 2019

@swift-ci Please test tensorflow

@rxwei

This comment has been minimized.

Copy link
Collaborator

commented Mar 17, 2019

@swift-ci please test tensorflow

@rxwei
rxwei approved these changes Mar 17, 2019
@bgogul

This comment has been minimized.

Copy link
Collaborator

commented Mar 18, 2019

@xeno-by what is the rationale for the change?

@marcrasi

This comment has been minimized.

Copy link
Collaborator

commented Mar 18, 2019

@swift-ci please test tensorflow macos

@marcrasi

This comment has been minimized.

Copy link
Collaborator

commented Mar 18, 2019

These are to make the tests work in the piper import.

@marcrasi

This comment has been minimized.

Copy link
Collaborator

commented Mar 18, 2019

@swift-ci please test tensorflow macos

@xeno-by xeno-by merged commit b1d5198 into apple:tensorflow Mar 18, 2019
3 checks passed
3 checks passed
Swift Test Linux Platform (TensorFlow) Build finished. 11640 tests run, 10485 skipped, 0 failed.
Details
Swift Test Linux Platform with GPU (TensorFlow) Build finished. 11640 tests run, 10485 skipped, 0 failed.
Details
Swift Test macOS Platform (TensorFlow) Build finished. 11699 tests run, 10187 skipped, 0 failed.
Details
@xeno-by xeno-by deleted the xeno-by:topic/tensorflowruntime-tests branch Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.