Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous cleanup and consolidation for implementation-only checking #23972

Merged

Conversation

Projects
None yet
3 participants
@jrose-apple
Copy link
Member

jrose-apple commented Apr 11, 2019

  • Adjust the implementation-only diagnostics to sound more similar
  • Don't bother checking implementation-only import use for accessors
  • Consolidate names of implementation-only checking functions as "exportability"

jrose-apple added some commits Apr 11, 2019

Adjust the implementation-only diagnostics to sound more similar
John and I had slightly different styles when adding these; better
to keep them in harmony.
Don't bother checking implementation-only import use for accessors
Their associated AbstractStorageDecl is already being checked, and
will produce a better error.
Consolidate names of implementation-only checking as "exportability"
Another place where John and I used different terms.
@jrose-apple

This comment has been minimized.

Copy link
Member Author

jrose-apple commented Apr 11, 2019

@swift-ci Please smoke test

@jrose-apple

This comment has been minimized.

Copy link
Member Author

jrose-apple commented Apr 11, 2019

That second one's actually semantics-changing, but it's also the simplest diff.

@jrose-apple

This comment has been minimized.

Copy link
Member Author

jrose-apple commented Apr 12, 2019

@swift-ci Please smoke test Linux

1 similar comment
@jrose-apple

This comment has been minimized.

Copy link
Member Author

jrose-apple commented Apr 12, 2019

@swift-ci Please smoke test Linux

@jrose-apple jrose-apple merged commit d4a5740 into apple:master Apr 12, 2019

2 checks passed

Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform (smoke test)
Details

@jrose-apple jrose-apple deleted the jrose-apple:implementation-only-implementation---only branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.