Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update “unable to load standard library” test #23990

Merged
merged 1 commit into from Apr 13, 2019

Conversation

Projects
None yet
3 participants
@brentdax
Copy link
Collaborator

brentdax commented Apr 12, 2019

One of the subtests of Misc/fatal_error.swift assumes that Swift.swiftmodule is located purely based on the resource directory. It can now also be located in the SDK, so the test needs to be updated. Fixes rdar://problem/49665477.

I'm waiting for some test results before I merge this, but we can review and PR-test it in the mean time.

Update “unable to load standard library” test
One of the subtests of Misc/fatal_error.swift assumes that Swift.swiftmodule is located purely based on the resource directory. It can now also be located in the SDK, so the test needs to be updated. Fixes <rdar://problem/49665477>.

@brentdax brentdax requested a review from jrose-apple Apr 12, 2019

@brentdax

This comment has been minimized.

Copy link
Collaborator Author

brentdax commented Apr 12, 2019

@swift-ci please test

@jrose-apple
Copy link
Member

jrose-apple left a comment

Whoops, good catch!

@swift-ci

This comment has been minimized.

Copy link
Contributor

swift-ci commented Apr 12, 2019

Build failed
Swift Test OS X Platform
Git Sha - c854d40

@brentdax

This comment has been minimized.

Copy link
Collaborator Author

brentdax commented Apr 12, 2019

@swift-ci please test macOS platform

@swift-ci

This comment has been minimized.

Copy link
Contributor

swift-ci commented Apr 12, 2019

Build failed
Swift Test Linux Platform
Git Sha - c854d40

@brentdax

This comment has been minimized.

Copy link
Collaborator Author

brentdax commented Apr 12, 2019

@swift-ci please test linux platform

@swift-ci

This comment has been minimized.

Copy link
Contributor

swift-ci commented Apr 13, 2019

Build failed
Swift Test Linux Platform
Git Sha - c854d40

@brentdax

This comment has been minimized.

Copy link
Collaborator Author

brentdax commented Apr 13, 2019

Both of those were full disks.

@brentdax

This comment has been minimized.

Copy link
Collaborator Author

brentdax commented Apr 13, 2019

@swift-ci please smoke test linux platform

@brentdax brentdax merged commit ee65d91 into apple:master Apr 13, 2019

3 of 4 checks passed

Swift Test Linux Platform No test results found.
Details
Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform No test results found.
Details
Swift Test OS X Platform (smoke test)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.