Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] [TypeChecker] Rephrase platforms in availability diagnostics #24681

Merged

Conversation

Projects
None yet
1 participant
@brentdax
Copy link
Collaborator

commented May 10, 2019

This PR cherry-picks #24334 to swift-5.1-branch. Master PR reviewed by @jrose-apple.

This does several different things to improve how platforms are described in availability diagnostics:

• Mentions the platform in diagnostics for platform-specific @available(unavailable) attributes.
• Replaces “OS X” with “macOS”.
• Replaces “fooOS application extension” with “application extensions for fooOS”.
• Replaces “on fooOS” with “in fooOS”.

Fixes rdar://problem/49963341.

(If you want to review this, turn on "Hide whitespace changes" in the diff settings—this PR reindents a lot more code than it actually rewrites.)

Merge pull request #24334 from brentdax/wherefore-art-thou-api
 [TypeChecker] Rephrase platforms in availability diagnostics
@brentdax

This comment has been minimized.

Copy link
Collaborator Author

commented May 10, 2019

@swift-ci test

@brentdax brentdax merged commit 7e21820 into apple:swift-5.1-branch May 11, 2019

4 checks passed

Swift Test Linux Platform No test results found.
Details
Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform No test results found.
Details
Swift Test OS X Platform (smoke test)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.