Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Re-add FrontendObserver methods #24917

Merged
merged 1 commit into from May 21, 2019

Conversation

Projects
None yet
3 participants
@harlanhaskins
Copy link
Collaborator

commented May 20, 2019

These observer methods were used by external clients. Since we no longer
have the granularity between diagnostics and optimization, they're
rolled into a new observer callback, performedSILProcessing.

This (effectively) reverts commit 7b43e1d.

@harlanhaskins

This comment has been minimized.

Copy link
Collaborator Author

commented May 20, 2019

@swift-ci please smoke test

Show resolved Hide resolved include/swift/FrontendTool/FrontendTool.h Outdated
[Frontend] Re-add FrontendObserver methods
These observer methods were used by external clients. Since we no longer
have the granularity between diagnostics and optimization, they're
rolled into a new observer callback, `performedSILProcessing`.

This (effectively) reverts commit 7b43e1d.

@harlanhaskins harlanhaskins force-pushed the harlanhaskins:a-passing-observation branch to 23655e5 May 20, 2019

@harlanhaskins harlanhaskins requested a review from jrose-apple May 20, 2019

@harlanhaskins

This comment has been minimized.

Copy link
Collaborator Author

commented May 21, 2019

@swift-ci please test

@swift-ci

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

Build failed
Swift Test OS X Platform
Git Sha - 57031dd18838f6f207568e65b549359bbab63b90

@swift-ci

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

Build failed
Swift Test Linux Platform
Git Sha - 57031dd18838f6f207568e65b549359bbab63b90

@harlanhaskins harlanhaskins merged commit ca5b94f into apple:master May 21, 2019

4 checks passed

Swift Test Linux Platform No test results found.
Details
Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform No test results found.
Details
Swift Test OS X Platform (smoke test)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.