Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mathable for 5.1 branch #25302

Open
wants to merge 7 commits into
base: swift-5.1-branch
from

Conversation

Projects
None yet
2 participants
@stephentyrone
Copy link
Member

commented Jun 7, 2019

This PR contains the protocols and static functions for SE-0246. It is a cherry pick of #23824, #24187, and #24784 for 5.1 branch.

@stephentyrone stephentyrone requested a review from airspeedswift Jun 7, 2019

@stephentyrone

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

@swift-ci please test

@stephentyrone

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

@swift-ci please test source compatibility

@stephentyrone

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

@swift-ci please test

@stephentyrone

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

@swift-ci please test source compatibility

@swift-ci

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

Build failed
Swift Test Linux Platform
Git Sha - 80ee75108304de229893918840e25732be99723c

@swift-ci

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

Build failed
Swift Test OS X Platform
Git Sha - 80ee75108304de229893918840e25732be99723c

@stephentyrone

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2019

@swift-ci please test

@stephentyrone

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2019

@swift-ci please test source compatibility

@swift-ci

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2019

Build failed
Swift Test Linux Platform
Git Sha - e0e1055e7873844dc679e8c793f192fb3b8dbb64

@swift-ci

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2019

Build failed
Swift Test OS X Platform
Git Sha - e0e1055e7873844dc679e8c793f192fb3b8dbb64

stephentyrone added some commits Apr 17, 2019

SE-0246: Protocols and static functions (#23824)
This implements the protocols and static functions proposed in SE-0246, plus some initial test coverage. It also has some rough accompanying cleanup of tgmath. It does not include the globals (on scalars or SIMD types) nor does it deprecate much in tgmath.h.
Add availability information to the new Math function protocols (#24187)
* Add availability information to the new Math function protocols

The protocols ElementaryFunctions, RealFunctions, and Real are new in Swift 5.1 and accordingly need to have availability attached to them for platforms that are ABI-stable. The actual implementation hooks (static functions) are unconditionally defined on scalar types and marked @_alwaysEmitIntoClient, so they are available even when targeting older library versions, but the protocols themselves, and anything defined in terms of them (the global functions and the SIMD extensions) is only available when targeting library versions that have the new protocols.

* Additionally provide concrete implementations of signGamma for each stdlib-builtin floating-point type.

* Remove Real[Functions] protocols pending re-review

Temporarily pull these back so we can make minor tweaks to the design and get a re-review on SE.
Deprecate nearbyint and rint on CGFloat (#24784)
These functions have never actually been supported in Swift, because Swift does not model the dynamic floating point environment. They may have worked occasionally in the past, but that was only accidental. Deprecate them with an explanatory message.

@stephentyrone stephentyrone force-pushed the stephentyrone:mathable-5.1 branch to 063e841 Jun 12, 2019

@stephentyrone

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2019

@swift-ci test

@stephentyrone

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2019

@swift-ci test source compatibility

@swift-ci

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Build failed
Swift Test Linux Platform
Git Sha - 3900c95d90d83a77bf8235d699d898ea75dd7d7a

@swift-ci

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Build failed
Swift Test OS X Platform
Git Sha - 3900c95d90d83a77bf8235d699d898ea75dd7d7a

@stephentyrone

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2019

@swift-ci please smoke test

@stephentyrone

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2019

@swift-ci please test

@stephentyrone

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2019

@swift-ci please test source compatibility

@swift-ci

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

Build failed
Swift Test OS X Platform
Git Sha - 8cf461e

@swift-ci

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

Build failed
Swift Test Linux Platform
Git Sha - 8cf461e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.