ClangImporter: Fix diagnostics for NS* prefix stripping from generic types #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…types We were failing to create an unavailable TypeAlias for the old name in the case the renamed type was generic, leading to poor diagnostics. Also, Sema resolves generic TypeAliases very early, while building a Type from a TypeRepr -- this means the unavailable/deprecated check runs too late to catch generic TypeAlises. Add a hack where we preserve a reference to the original TypeAliasDecl by way of constructing a SubstitutedType which desugars to the replacement type, rather than resolving the replacement type directly, so that the availability check can pick it up. A better fix for this would be to introduce a BoundGenericAliasType sugared type, but that's a bigger change that can come later. Fixes <rdar://problem/26206263>.
|
@swift-ci Please test |
|
@DougGregor Can you please review? |
|
@swift-ci test linux |
|
Weird use of SubstitutedType, but it makes perfect sense to do this for Swift 3 preview 1. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Radar: rdar://problem/26206263