Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StringInterpolationProtocol validation crasher #27480

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@brentdax
Copy link
Contributor

commented Oct 2, 2019

Some old circularity-breaking code caused an unexpected null type, which led to crashes in the decl checker when trying to check that an appendInterpolation method in a different file would satisfy the informal requirement for one in a StringInterpolationProtocol conformer. This code appears to now be unnecessary, so this commit removes it. Fixes rdar://problem/55864759.

Some old circularity-breaking code caused an unexpected null type, which led to crashes in the decl checker when trying to check that an `appendInterpolation` method in a different file would satisfy the informal requirement for one in a StringInterpolationProtocol conformer. This code appears to now be unnecessary, so this commit removes it. Fixes rdar://problem/55864759.
@brentdax

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

@swift-ci please smoke test

@brentdax brentdax requested a review from slavapestov Oct 2, 2019
@brentdax brentdax merged commit 14477a7 into apple:master Oct 2, 2019
2 checks passed
2 checks passed
Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform (smoke test)
Details
@brentdax brentdax deleted the brentdax:absence-of-results branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.