Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ownership] Allow for the ownership verifier to be run in non-asserts… #27499

Merged

Conversation

@gottesmm
Copy link
Member

commented Oct 2, 2019

… builds if -sil-verify-all is set.

This is matching the behavior of the rest of the verifier. NOTE: Both early exit
if said flag is not set, so this should not hit compile time in any way unless
the flag is set (in which case someone is asking for more verification...).

While I was here, I also noticed an ancillary bug where we were not checking if
a value was from in a block that was in a SILGlobalVariable or a SILFunction. We
already had a check that stopped this early when validating ownership of
SILInstructions. I guess we have never had a situation where the verifier was
given values to run on SILGlobalVariable blocks.

@gottesmm gottesmm requested a review from brentdax Oct 2, 2019
@gottesmm

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

@swift-ci smoke test

… builds if -sil-verify-all is set.

This is matching the behavior of the rest of the verifier. NOTE: Both early exit
if said flag is not set, so this should not hit compile time in any way unless
the flag is set (in which case someone is asking for more verification...).

While I was here, I also noticed an ancillary bug where we were not checking if
a value was from in a block that was in a SILGlobalVariable or a SILFunction. We
already had a check that stopped this early when validating ownership of
SILInstructions. I guess we have never had a situation where the verifier was
given values to run on SILGlobalVariable blocks.
@gottesmm gottesmm force-pushed the gottesmm:pr-dc6371871f1797246355f4fc6795f1d0116e360a branch from 923eff6 to d535e3e Oct 2, 2019
@gottesmm

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

@swift-ci smoke test

3 similar comments
@gottesmm

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

@swift-ci smoke test

@gottesmm

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

@swift-ci smoke test

@gottesmm

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

@swift-ci smoke test

@gottesmm

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

@swift-ci smoke test os x platform

@gottesmm gottesmm merged commit 6d789e3 into apple:master Oct 2, 2019
2 checks passed
2 checks passed
Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform (smoke test)
Details
@gottesmm gottesmm deleted the gottesmm:pr-dc6371871f1797246355f4fc6795f1d0116e360a branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.