Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AST: Fix computeSelfParam() to respect __consuming on class methods #29579

Merged

Conversation

@slavapestov
Copy link
Member

slavapestov commented Jan 31, 2020

Fixes rdar://problem/58887618.

@slavapestov slavapestov requested a review from CodaFi Jan 31, 2020
@slavapestov

This comment has been minimized.

Copy link
Member Author

slavapestov commented Jan 31, 2020

@swift-ci Please test source compatibility

@CodaFi
CodaFi approved these changes Feb 1, 2020
@slavapestov slavapestov force-pushed the slavapestov:no-ethical-consumption-of-class-methods branch from 07081b5 to 62ca2aa Feb 1, 2020
@slavapestov slavapestov merged commit 7cabef8 into apple:master Feb 1, 2020
3 of 4 checks passed
3 of 4 checks passed
Swift Source Compatibility Suite on macOS Platform (Release) Build started.
Details
Swift Source Compatibility Suite on macOS Platform (Debug)
Details
Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform (smoke test)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.