Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[SR-1813] Fix archetype access path binding #3093
What's in this pull request?
Fixes a regression from Swift 2.2 where the configuration reported in SR-1813 would cause the compiler to forget to setup archetype access paths which would blow up witness table gen.
Resolved bug number: (SR-1813)
Before merging this pull request to apple/swift repository:
|All supported platforms||@swift-ci Please smoke test|
|All supported platforms||@swift-ci Please smoke test and merge|
|OS X platform||@swift-ci Please smoke test OS X platform|
|Linux platform||@swift-ci Please smoke test Linux platform|
|All supported platforms||@swift-ci Please test|
|All supported platforms||@swift-ci Please test and merge|
|OS X platform||@swift-ci Please test OS X platform|
|OS X platform||@swift-ci Please benchmark|
|Linux platform||@swift-ci Please test Linux platform|
|Python||@swift-ci Please Python lint|
Note: Only members of the Apple organization can trigger swift-ci.
Generally looks okay, but:
Thank you @CodaFi
However, I found another crash on this commit but I cannot tell whether this is same issue or not. (around
The new case is below:
will result in:
Moreover, removing 'protocol P2' and using 'P1' instead of 'P2' still reproduce same error message and make the case shortest example. (I think using P1 and P2 is more general case).