Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experiment] Make ObjCSelector direct lookup more eager #31754

Closed
wants to merge 1 commit into from

Conversation

hamishknight
Copy link
Collaborator

No description provided.

@apple apple deleted a comment from swift-ci May 13, 2020
@apple apple deleted a comment from swift-ci May 13, 2020
@apple apple deleted a comment from swift-ci May 13, 2020
@swift-ci

This comment has been minimized.

@swift-ci

This comment has been minimized.

@swift-ci

This comment has been minimized.

@hamishknight
Copy link
Collaborator Author

@swift-ci please test compiler performance

@apple apple deleted a comment from swift-ci May 18, 2020
@swift-ci
Copy link
Collaborator

Summary for master full

Unexpected test results, excluded stats for RxCocoa, SwifterSwift, Base64CoderSwiftUI

Regressions found (see below)

Debug-batch

debug-batch brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 73,671,363,076,237 73,665,472,324,193 -5,890,752,044 -0.01%
LLVM.NumLLVMBytesOutput 1,873,217,614 1,873,215,858 -1,756 -0.0%
time.swift-driver.wall 6202.5s 6187.1s -15.4s -0.25%

debug-batch detailed

Regressed (7)
name old new delta delta_pct
AST.ImportSetFoldHit 179,039 181,545 2,506 1.4% ⛔
Driver.NumDriverPipePolls 69,849 70,704 855 1.22% ⛔
Driver.NumDriverPipeReads 56,522 57,287 765 1.35% ⛔
Sema.ClassAncestryFlagsRequest 119,418 121,241 1,823 1.53% ⛔
Sema.IsStaticRequest 988,971 999,693 10,722 1.08% ⛔
Sema.NamingPatternRequest 250,398 257,542 7,144 2.85% ⛔
Sema.ResultTypeRequest 717,718 725,661 7,943 1.11% ⛔
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (232)
name old new delta delta_pct
AST.ImportSetCacheHit 2,008,858 2,017,779 8,921 0.44%
AST.ImportSetCacheMiss 576,565 579,065 2,500 0.43%
AST.ImportSetFoldMiss 397,526 397,520 -6 -0.0%
AST.ModuleShadowCacheHit 3,739 3,739 0 0.0%
AST.ModuleShadowCacheMiss 1,986 1,986 0 0.0%
AST.ModuleVisibilityCacheHit 41,675 41,675 0 0.0%
AST.ModuleVisibilityCacheMiss 10,561 10,561 0 0.0%
AST.NumASTBytesAllocated 74,743,611,448 74,792,861,543 49,250,095 0.07%
AST.NumASTScopeLookups 4,471,198 4,494,974 23,776 0.53%
AST.NumBraceStmtASTScopeExpansions 650,431 649,781 -650 -0.1%
AST.NumBraceStmtASTScopes 650,431 649,781 -650 -0.1%
AST.NumDecls 146,061 146,061 0 0.0%
AST.NumDependencies 447,378 447,311 -67 -0.01%
AST.NumIterableTypeBodyASTScopeExpansions 288,960 291,048 2,088 0.72%
AST.NumIterableTypeBodyASTScopes 372,316 375,832 3,516 0.94%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 365,013 365,013 0 0.0%
AST.NumLocalTypeDecls 255 255 0 0.0%
AST.NumModuleLookupClassMember 6,993 6,993 0 0.0%
AST.NumModuleLookupValue 56,924,181 57,216,324 292,143 0.51%
AST.NumObjCMethods 25,367 25,367 0 0.0%
AST.NumOperators 589 589 0 0.0%
AST.NumPrecedenceGroups 93 93 0 0.0%
AST.NumReferencedDynamicNames 191 191 0 0.0%
AST.NumReferencedMemberNames 7,723,619 7,776,378 52,759 0.68%
AST.NumReferencedTopLevelNames 615,824 615,824 0 0.0%
AST.NumSourceBuffers 603,729 603,729 0 0.0%
AST.NumSourceLines 4,858,975 4,858,975 0 0.0%
AST.NumSourceLinesPerSecond 2,765,188 2,767,862 2,674 0.1%
AST.NumTotalClangImportedEntities 2,452,592 2,452,109 -483 -0.02%
Driver.ChildrenMaxRSS 276,454,776,832 276,066,396,160 -388,380,672 -0.14%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 29,018 29,018 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.MaxMallocUsage 1,683,463,298,072 1,682,953,361,712 -509,936,360 -0.03%
Frontend.NumInstructionsExecuted 73,671,363,076,237 73,665,472,324,193 -5,890,752,044 -0.01%
Frontend.NumProcessFailures 0 0 0 0.0%
IRGen.IRGenSourceFileRequest 27,704 27,704 0 0.0%
IRGen.IRGenWholeModuleRequest 20 20 0 0.0%
IRModule.NumGOTEntries 249,271 249,271 0 0.0%
IRModule.NumIRAliases 203,652 203,652 0 0.0%
IRModule.NumIRBasicBlocks 7,063,569 7,063,569 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 3,550,769 3,550,769 0 0.0%
IRModule.NumIRGlobals 3,850,996 3,850,996 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 90,718,830 90,718,830 0 0.0%
IRModule.NumIRNamedMetaData 140,120 140,120 0 0.0%
IRModule.NumIRValueSymbols 6,723,431 6,723,431 0 0.0%
LLVM.NumLLVMBytesOutput 1,873,217,614 1,873,215,858 -1,756 -0.0%
Parse.CodeCompletionSecondPassRequest 0 0 0 0.0%
Parse.NumFunctionsParsed 280,363 280,363 0 0.0%
Parse.NumIterableDeclContextParsed 966,616 967,973 1,357 0.14%
Parse.ParseAbstractFunctionBodyRequest 257,915 257,915 0 0.0%
Parse.ParseMembersRequest 795,491 796,848 1,357 0.17%
Parse.ParseSourceFileRequest 593,126 593,126 0 0.0%
SILGen.ParseSILModuleRequest 0 0 0 0.0%
SILGen.SILGenerationRequest 29,006 29,006 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 1,772,287 1,772,287 0 0.0%
SILModule.NumSILGenGlobalVariables 55,392 55,392 0 0.0%
SILModule.NumSILGenVtables 19,137 19,137 0 0.0%
SILModule.NumSILGenWitnessTables 75,903 75,903 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 2,611,485 2,611,485 0 0.0%
SILModule.NumSILOptGlobalVariables 57,108 57,108 0 0.0%
SILModule.NumSILOptVtables 32,429 32,429 0 0.0%
SILModule.NumSILOptWitnessTables 175,748 175,748 0 0.0%
SILOptimizer.ExecuteSILPipelineRequest 112,178 112,178 0 0.0%
Sema.AbstractGenericSignatureRequest 39,702 39,746 44 0.11%
Sema.AccessLevelRequest 16,623,642 16,659,742 36,100 0.22%
Sema.AnyObjectLookupRequest 283 283 0 0.0%
Sema.AreAllStoredPropertiesDefaultInitableRequest 24,616 24,689 73 0.3%
Sema.AttachedFunctionBuilderRequest 181 181 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 591,652 591,746 94 0.02%
Sema.AttachedPropertyWrappersRequest 2,723,669 2,727,189 3,520 0.13%
Sema.CallerSideDefaultArgExprRequest 79,503 79,503 0 0.0%
Sema.CheckRedeclarationRequest 1,014,210 1,014,210 0 0.0%
Sema.ClosureHasExplicitResultRequest 93,515 93,515 0 0.0%
Sema.CollectOverriddenDeclsRequest 10,762,802 10,768,899 6,097 0.06%
Sema.CompareDeclSpecializationRequest 515,289 514,966 -323 -0.06%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 501 501 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 60,867 60,980 113 0.19%
Sema.DefaultArgumentExprRequest 39,907 39,907 0 0.0%
Sema.DefaultArgumentInitContextRequest 259 259 0 0.0%
Sema.DefaultDefinitionTypeRequest 8,722 8,722 0 0.0%
Sema.DefaultTypeRequest 502,266 502,266 0 0.0%
Sema.DerivativeAttrOriginalDeclRequest 0 0 0 0.0%
Sema.DifferentiableAttributeTypeCheckRequest 0 0 0 0.0%
Sema.DirectLookupRequest 36,707,572 36,871,135 163,563 0.45%
Sema.DirectOperatorLookupRequest 593,591 593,466 -125 -0.02%
Sema.DirectPrecedenceGroupLookupRequest 147,073 147,073 0 0.0%
Sema.DynamicallyReplacedDeclRequest 1,108,433 1,108,433 0 0.0%
Sema.EmittedMembersRequest 28,997 28,997 0 0.0%
Sema.EnumRawTypeRequest 27,238 27,238 0 0.0%
Sema.EnumRawValuesRequest 10,961 10,961 0 0.0%
Sema.ExistentialConformsToSelfRequest 14,525 14,512 -13 -0.09%
Sema.ExistentialTypeSupportedRequest 18,521 18,521 0 0.0%
Sema.ExpandASTScopeRequest 8,094,301 8,115,191 20,890 0.26%
Sema.ExtendedNominalRequest 926,554 926,554 0 0.0%
Sema.ExtendedTypeRequest 87,562 88,273 711 0.81%
Sema.FragileFunctionKindRequest 1,967,704 1,976,551 8,847 0.45%
Sema.FunctionBuilderTypeRequest 181 181 0 0.0%
Sema.FunctionOperatorRequest 74,345 74,345 0 0.0%
Sema.GenericParamListRequest 12,177,310 12,201,558 24,248 0.2%
Sema.GenericSignatureRequest 2,887,030 2,897,037 10,007 0.35%
Sema.GetDestructorRequest 29,504 29,504 0 0.0%
Sema.HasCircularInheritanceRequest 24,552 24,552 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 10,674 10,674 0 0.0%
Sema.HasCircularRawValueRequest 9,296 9,296 0 0.0%
Sema.HasDefaultInitRequest 59,781 59,854 73 0.12%
Sema.HasDynamicCallableAttributeRequest 0 0 0 0.0%
Sema.HasDynamicMemberLookupAttributeRequest 695,843 695,876 33 0.0%
Sema.HasImplementationOnlyImportsRequest 593,126 593,126 0 0.0%
Sema.HasMemberwiseInitRequest 21,772 21,772 0 0.0%
Sema.HasMissingDesignatedInitializersRequest 27,541 27,541 0 0.0%
Sema.HasUserDefinedDesignatedInitRequest 59,792 59,854 62 0.1%
Sema.InferredGenericSignatureRequest 192,813 192,817 4 0.0%
Sema.InheritedDeclsReferencedRequest 6,771,683 6,768,977 -2,706 -0.04%
Sema.InheritedProtocolsRequest 711,132 711,431 299 0.04%
Sema.InheritedTypeRequest 326,437 326,342 -95 -0.03%
Sema.InheritsSuperclassInitializersRequest 30,271 30,333 62 0.2%
Sema.InitKindRequest 102,608 102,673 65 0.06%
Sema.InterfaceTypeRequest 17,372,549 17,395,155 22,606 0.13%
Sema.IsABICompatibleOverrideRequest 141,210 141,210 0 0.0%
Sema.IsAccessorTransparentRequest 330,467 330,467 0 0.0%
Sema.IsCallableNominalTypeRequest 2,170 2,170 0 0.0%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDynamicRequest 1,819,286 1,819,420 134 0.01%
Sema.IsFinalRequest 3,161,087 3,162,207 1,120 0.04%
Sema.IsGetterMutatingRequest 453,282 454,330 1,048 0.23%
Sema.IsImplicitlyUnwrappedOptionalRequest 2,572,150 2,573,759 1,609 0.06%
Sema.IsObjCRequest 1,676,728 1,687,743 11,015 0.66%
Sema.IsSetterMutatingRequest 385,315 385,547 232 0.06%
Sema.LazyStoragePropertyRequest 3,005 3,005 0 0.0%
Sema.LookupAllConformancesInContextRequest 85,535 85,535 0 0.0%
Sema.LookupConformanceInModuleRequest 39,376,098 39,387,500 11,402 0.03%
Sema.LookupInModuleRequest 7,869,663 7,886,545 16,882 0.21%
Sema.LookupInfixOperatorRequest 98,186 98,186 0 0.0%
Sema.LookupPostfixOperatorRequest 215 215 0 0.0%
Sema.LookupPrecedenceGroupRequest 32,647 32,647 0 0.0%
Sema.LookupPrefixOperatorRequest 716 716 0 0.0%
Sema.MangleLocalTypeDeclRequest 510 510 0 0.0%
Sema.ModuleImplicitImportsRequest 14,478 14,478 0 0.0%
Sema.ModuleQualifiedLookupRequest 3,694,850 3,687,954 -6,896 -0.19%
Sema.NamedLazyMemberLoadSuccessCount 23,477,032 23,624,574 147,542 0.63%
Sema.NeedsNewVTableEntryRequest 721,869 721,869 0 0.0%
Sema.NumAccessorBodiesSynthesized 195,812 195,812 0 0.0%
Sema.NumAccessorsSynthesized 308,404 309,101 697 0.23%
Sema.NumConformancesDeserialized 11,742,192 11,749,562 7,370 0.06%
Sema.NumConstraintScopes 31,479,014 31,479,676 662 0.0%
Sema.NumConstraintsConsideredForEdgeContraction 103,433,792 103,433,438 -354 -0.0%
Sema.NumCrossImportsChecked 0 0 0 0.0%
Sema.NumCrossImportsFound 0 0 0 0.0%
Sema.NumCyclicOneWayComponentsCollapsed 269 269 0 0.0%
Sema.NumDeclsDeserialized 93,568,021 93,596,412 28,391 0.03%
Sema.NumDeclsTypechecked 1,462,619 1,462,619 0 0.0%
Sema.NumGenericSignatureBuilders 1,653,219 1,653,926 707 0.04%
Sema.NumLazyIterableDeclContexts 11,069,047 11,069,036 -11 -0.0%
Sema.NumLazyRequirementSignatures 1,108,350 1,108,531 181 0.02%
Sema.NumLazyRequirementSignaturesLoaded 793,560 793,644 84 0.01%
Sema.NumLeafScopes 20,116,068 20,116,838 770 0.0%
Sema.NumTypesDeserialized 28,695,173 28,696,937 1,764 0.01%
Sema.NumTypesValidated 687,199 688,544 1,345 0.2%
Sema.NumUnloadedLazyIterableDeclContexts 6,995,807 6,992,467 -3,340 -0.05%
Sema.OpaqueReadOwnershipRequest 294,350 295,839 1,489 0.51%
Sema.OpaqueResultTypeRequest 182 182 0 0.0%
Sema.OperatorPrecedenceGroupRequest 749 749 0 0.0%
Sema.OverriddenDeclsRequest 3,013,455 3,034,285 20,830 0.69%
Sema.ParamSpecifierRequest 1,348,684 1,361,939 13,255 0.98%
Sema.PatternBindingEntryRequest 510,393 511,738 1,345 0.26%
Sema.PatternTypeRequest 586,126 587,471 1,345 0.23%
Sema.PreCheckFunctionBuilderRequest 296 296 0 0.0%
Sema.PropertyWrapperBackingPropertyInfoRequest 584,855 584,949 94 0.02%
Sema.PropertyWrapperBackingPropertyTypeRequest 591,652 591,746 94 0.02%
Sema.PropertyWrapperLValuenessRequest 203 203 0 0.0%
Sema.PropertyWrapperMutabilityRequest 640,000 641,049 1,049 0.16%
Sema.PropertyWrapperTypeInfoRequest 107 107 0 0.0%
Sema.ProtocolRequiresClassRequest 46,076 46,019 -57 -0.12%
Sema.ProvideDefaultImplForRequest 10,762,802 10,768,899 6,097 0.06%
Sema.QualifiedLookupRequest 6,110,044 6,134,973 24,929 0.41%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RequirementRequest 120,800 120,803 3 0.0%
Sema.RequirementSignatureRequest 863,987 863,971 -16 -0.0%
Sema.RequiresOpaqueAccessorsRequest 1,371,205 1,372,622 1,417 0.1%
Sema.RequiresOpaqueModifyCoroutineRequest 284,183 285,902 1,719 0.6%
Sema.ResolveEffectiveMemberwiseInitRequest 0 0 0 0.0%
Sema.ResolveImplicitMemberRequest 420,727 421,742 1,015 0.24%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResolveTypeEraserTypeRequest 0 0 0 0.0%
Sema.ResolveTypeRequest 3,768,570 3,790,794 22,224 0.59%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SPIGroupsRequest 19,076,797 19,095,773 18,976 0.1%
Sema.ScopedImportLookupRequest 1,076 1,076 0 0.0%
Sema.SelfAccessKindRequest 691,533 692,866 1,333 0.19%
Sema.SelfBoundsFromWhereClauseRequest 2,030,157 2,027,444 -2,713 -0.13%
Sema.SetterAccessLevelRequest 152,213 152,278 65 0.04%
Sema.SimpleDidSetRequest 3,237,694 3,237,278 -416 -0.01%
Sema.StorageImplInfoRequest 1,536,129 1,536,887 758 0.05%
Sema.StoredPropertiesAndMissingMembersRequest 34,808 34,808 0 0.0%
Sema.StoredPropertiesRequest 398,053 398,053 0 0.0%
Sema.StructuralTypeRequest 2,340 2,340 0 0.0%
Sema.SuperclassDeclRequest 538,907 540,885 1,978 0.37%
Sema.SuperclassTypeRequest 63,098 63,098 0 0.0%
Sema.SynthesizeAccessorRequest 308,404 309,101 697 0.23%
Sema.SynthesizeDefaultInitRequest 5,680 5,680 0 0.0%
Sema.SynthesizeMemberwiseInitRequest 3,791 3,791 0 0.0%
Sema.TypeCheckFunctionBodyUntilRequest 548,128 548,128 0 0.0%
Sema.TypeCheckSourceFileRequest 28,024 28,024 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 31,848 31,847 -1 -0.0%
Sema.TypeEraserHasViableInitRequest 0 0 0 0.0%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 10,287 10,287 0 0.0%
Sema.USRGenerationRequest 12,332,906 12,336,456 3,550 0.03%
Sema.UnderlyingTypeDeclsReferencedRequest 337,934 337,891 -43 -0.01%
Sema.UnderlyingTypeRequest 40,336 40,448 112 0.28%
Sema.UnqualifiedLookupRequest 4,624,186 4,647,962 23,776 0.51%
Sema.ValidatePrecedenceGroupRequest 183,900 183,900 0 0.0%
Sema.ValueWitnessRequest 72,012 72,454 442 0.61%
TBDGen.GenerateTBDRequest 27,724 27,724 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 55,055,181,799,727 55,116,882,854,537 61,701,054,810 0.11%
LLVM.NumLLVMBytesOutput 1,875,599,114 1,875,599,822 708 0.0%
time.swift-driver.wall 10104.0s 10121.1s 17.1s 0.17%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (17)
name old new delta delta_pct
AST.NumLoadedModules 27,540 27,540 0 0.0%
AST.NumTotalClangImportedEntities 474,358 474,358 0 0.0%
IRModule.NumIRBasicBlocks 4,972,663 4,972,663 0 0.0%
IRModule.NumIRFunctions 2,877,666 2,877,666 0 0.0%
IRModule.NumIRGlobals 3,386,079 3,386,079 0 0.0%
IRModule.NumIRInsts 50,140,702 50,140,702 0 0.0%
IRModule.NumIRValueSymbols 5,894,064 5,894,064 0 0.0%
LLVM.NumLLVMBytesOutput 1,875,599,114 1,875,599,822 708 0.0%
SILModule.NumSILGenFunctions 1,238,653 1,238,653 0 0.0%
SILModule.NumSILOptFunctions 1,038,075 1,038,075 0 0.0%
Sema.NumConformancesDeserialized 3,580,159 3,580,159 0 0.0%
Sema.NumConstraintScopes 31,010,585 31,010,592 7 0.0%
Sema.NumDeclsDeserialized 11,237,891 11,237,891 0 0.0%
Sema.NumGenericSignatureBuilders 279,216 279,216 0 0.0%
Sema.NumLazyIterableDeclContexts 1,402,856 1,402,856 0 0.0%
Sema.NumTypesDeserialized 5,436,544 5,436,544 0 0.0%
Sema.NumTypesValidated 495,108 495,108 0 0.0%

@shahmishal
Copy link
Member

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

  • How to change the base branch: (Link)
  • More detail about the branch update: (Link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants