[SR-14050][Sema] Removing check on subtype validation at matchFunctionRepresentations #35580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test source compatibility |
|
@swift-ci Please test source compatibility Release |
xedin
approved these changes
Jan 25, 2021
…atchFunctionRepresentations
LucianoPAlmeida
force-pushed
the
SR-14050
branch
from
fc6e4ba
to
18e604a
Compare
varungandhi-apple
approved these changes
Jan 25, 2021
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For what I could see and test seems is just fine to remove this check and just adding a bit more information. Most relations between function types are handled by conversions.
I'm running the tests to make sure, but let me know if you think there are some situation where the check still be necessary.
Resolves SR-14050.