New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lit] Rename config.targets_to_build => config.llvm_targets and allow… #3577

Merged
merged 2 commits into from Jul 19, 2016

Conversation

Projects
None yet
3 participants
@gottesmm
Member

gottesmm commented Jul 18, 2016

What's in this pull request?

Resolved bug number: (SR-)


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

… it to actually take on a value.

Previously this variable was always just "". Now we can grab the proper value
from LLVMConfig.cmake (given the recent cmake changes I made).

I need this so that we can REQUIRES tests based on the code generators that LLVM
was compiled with.

@gottesmm

This comment has been minimized.

Show comment
Hide comment
@gottesmm

gottesmm Jul 18, 2016

Member

@swift-ci Please smoke test and merge

Member

gottesmm commented Jul 18, 2016

@swift-ci Please smoke test and merge

@modocache

This comment has been minimized.

Show comment
Hide comment
@modocache

modocache Jul 18, 2016

Collaborator

I believe you'll need to make this same change in validation-test/lit.site.cfg.in and validation-test/lit.cfg. This confused me for a while when I was working on #1714 (comment). Improving this experience is being tracked in SR-1266.

Collaborator

modocache commented Jul 18, 2016

I believe you'll need to make this same change in validation-test/lit.site.cfg.in and validation-test/lit.cfg. This confused me for a while when I was working on #1714 (comment). Improving this experience is being tracked in SR-1266.

@gottesmm

This comment has been minimized.

Show comment
Hide comment
@gottesmm

gottesmm Jul 19, 2016

Member

@modocache I just forgot about it ; )

Member

gottesmm commented Jul 19, 2016

@modocache I just forgot about it ; )

@gottesmm

This comment has been minimized.

Show comment
Hide comment
@gottesmm

gottesmm Jul 19, 2016

Member

@swift-ci Please smoke test and merge

Member

gottesmm commented Jul 19, 2016

@swift-ci Please smoke test and merge

gottesmm added some commits Jul 19, 2016

[lit] Rename config.targets_to_build => config.llvm_code_generators a…
…nd allow it to actually take on a value.

Previously this variable was always just "". Now using the recent cmake changes
that I made, we can just grab the proper values from LLVMConfig.cmake.

I need this so that we can REQUIRES tests based on the code generators that
LLVM was compiled with.

To make it easy to show the dependency in the requires line, the requires
pattern to use is:

REQUIRES: CODEGENERATOR=...
@gottesmm

This comment has been minimized.

Show comment
Hide comment
@gottesmm

gottesmm Jul 19, 2016

Member

@swift-ci Please smoke test and merge

Member

gottesmm commented Jul 19, 2016

@swift-ci Please smoke test and merge

@swift-ci swift-ci merged commit 6b89664 into apple:master Jul 19, 2016

1 check was pending

Test and Merge (smoke test) Build started.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment