New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SourceKit] use "inproc" variant of SourceKit on Linux #3595

Merged
merged 1 commit into from Jul 19, 2016

Conversation

Projects
None yet
3 participants
@jpsim
Contributor

jpsim commented Jul 18, 2016

What's in this pull request?

Set the SWIFT_SOURCEKIT_USE_INPROC_LIBRARY cmake variable to TRUE when building on Linux because the interprocess version likely won't be available for quite some time given that libXPC hasn't yet been ported, and the in process version nearly works.

This is NFC since SourceKit still isn't built by default on Linux.

cc @akyrtzi @briancroom @modocache

Resolved bug number: (SR-1676)


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

[SourceKit] use "inproc" variant of SourceKit on Linux
since the interprocess version likely won't be available for quite some time
given that libXPC hasn't yet been ported, and the in process version nearly
works.

This is NFC since SourceKit still isn't built by default on Linux.
@modocache

This comment has been minimized.

Show comment
Hide comment
@modocache

modocache Jul 19, 2016

Collaborator

@swift-ci please test

Collaborator

modocache commented Jul 19, 2016

@swift-ci please test

@akyrtzi akyrtzi merged commit 02f3298 into apple:master Jul 19, 2016

2 checks passed

Swift Test Linux Platform Build finished.
Details
Swift Test OS X Platform Build finished.
Details

@jpsim jpsim deleted the jpsim:sourcekit-linux-inproc branch Jul 19, 2016

jpsim added a commit to jpsim/SourceKitten that referenced this pull request Jul 21, 2016

Improve Dockerfile
since apple/swift#3594 & apple/swift#3595 were recently merged, we can build
SourceKit without any patches to Swift! 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment