Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Introduce isDecl and getDeclType #36953

Merged
merged 1 commit into from Apr 20, 2021
Merged

Conversation

Azoy
Copy link
Member

@Azoy Azoy commented Apr 18, 2021

Alright, let's give this another go! This is resurrecting an older PR I made here: #27195 .

@Azoy Azoy requested a review from CodaFi April 18, 2021 05:36
@Azoy
Copy link
Member Author

Azoy commented Apr 19, 2021

@swift-ci please test

@swift-ci
Copy link
Collaborator

Build failed
Swift Test OS X Platform
Git Sha - ddad32354ae48b6ff40fd17b3838e34d2e664da9

@swift-ci
Copy link
Collaborator

Build failed
Swift Test Linux Platform
Git Sha - ddad32354ae48b6ff40fd17b3838e34d2e664da9

@Azoy Azoy force-pushed the isType-isDeclType branch 2 times, most recently from 8ee9eb5 to 102e3e3 Compare April 19, 2021 20:46
@Azoy
Copy link
Member Author

Azoy commented Apr 19, 2021

@swift-ci please test

@swift-ci
Copy link
Collaborator

Build failed
Swift Test OS X Platform
Git Sha - 102e3e30d26d65ee591a041e5bb2c2048603ca22

fix enum logic issue

fix tests

guard against null types
@Azoy
Copy link
Member Author

Azoy commented Apr 20, 2021

@swift-ci please test

@Azoy Azoy merged commit 444c35c into apple:main Apr 20, 2021
@Azoy Azoy deleted the isType-isDeclType branch April 20, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants