New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import @compatibility_alias as typealias #3745

Merged
merged 1 commit into from Jul 25, 2016

Conversation

Projects
None yet
4 participants
@ayanonagon
Contributor

ayanonagon commented Jul 25, 2016

What's in this pull request?

Objective-C’s @compatibility_alias compiler directive is imported as
a Swift typealias.

Note: For some reason the test that I wrote for this isn’t passing on my machine but @CodaFi said that it passes for him locally. A bit spooky so I’m curious how it does against CI.

Resolved bug number: (SR-1963)


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library only for macOS. Simulator standard libraries and
    device standard libraries are not built.
  3. lldb is not built.
  4. The test and validation-test targets are run only for macOS. The optimized
    version of these tests are not run.

A smoke test on Linux does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library incrementally.
  3. lldb is built incrementally.
  4. The swift test and validation-test targets are run. The optimized version of these
    tests are not run.
  5. lldb is tested.

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

Import @compatibility_alias as typealias
Objective-C’s @compatibility_alias compiler directive is imported as
a Swift typealias.
@DougGregor

This comment has been minimized.

Show comment
Hide comment
@DougGregor

DougGregor Jul 25, 2016

Member

LGTM, thanks!

@swift-ci please smoke test and merge

Member

DougGregor commented Jul 25, 2016

LGTM, thanks!

@swift-ci please smoke test and merge

@CodaFi

This comment has been minimized.

Show comment
Hide comment
@CodaFi

CodaFi Jul 25, 2016

Collaborator

@swift-ci please smoke test and merge

Collaborator

CodaFi commented Jul 25, 2016

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit bd4996e into apple:master Jul 25, 2016

1 check was pending

Test and Merge (smoke test) Build started.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment