New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SE-0117 #3882

Merged
merged 1 commit into from Aug 2, 2016

Conversation

Projects
None yet
5 participants
@rjmccall
Member

rjmccall commented Jul 30, 2016

What's in this pull request?

Resolved bug number: (SR-)


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library only for macOS. Simulator standard libraries and
    device standard libraries are not built.
  3. lldb is not built.
  4. The test and validation-test targets are run only for macOS. The optimized
    version of these tests are not run.

A smoke test on Linux does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library incrementally.
  3. lldb is built incrementally.
  4. The swift test and validation-test targets are run. The optimized version of these
    tests are not run.
  5. lldb is tested.

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@rjmccall

This comment has been minimized.

Show comment
Hide comment
@rjmccall

rjmccall Jul 30, 2016

Member

@swift-ci Please smoke test.

Member

rjmccall commented Jul 30, 2016

@swift-ci Please smoke test.

@ultramiraculous

This comment has been minimized.

Show comment
Hide comment
@ultramiraculous
Contributor

ultramiraculous commented Jul 30, 2016

10734326_526120340852998_1807512965_n

@gottesmm

This comment has been minimized.

Show comment
Hide comment
@gottesmm

gottesmm Jul 30, 2016

Member

@swift-ci Please smoke test

Member

gottesmm commented Jul 30, 2016

@swift-ci Please smoke test

@gottesmm

This comment has been minimized.

Show comment
Hide comment
@gottesmm

gottesmm Jul 30, 2016

Member

(just restarting the build for John)

Member

gottesmm commented Jul 30, 2016

(just restarting the build for John)

@rjmccall

This comment has been minimized.

Show comment
Hide comment
@rjmccall

rjmccall Jul 30, 2016

Member

@swift-ci Please test.

Member

rjmccall commented Jul 30, 2016

@swift-ci Please test.

@rjmccall

This comment has been minimized.

Show comment
Hide comment
@rjmccall

rjmccall Aug 1, 2016

Member

@swift-ci Please smoke test.

Member

rjmccall commented Aug 1, 2016

@swift-ci Please smoke test.

@rjmccall

This comment has been minimized.

Show comment
Hide comment
@rjmccall

rjmccall Aug 1, 2016

Member

@swift-ci Please smoke test.

Member

rjmccall commented Aug 1, 2016

@swift-ci Please smoke test.

@rjmccall

This comment has been minimized.

Show comment
Hide comment
@rjmccall

rjmccall Aug 1, 2016

Member

Okay, just the same failure about xctest.

@swift-ci Please test.

Member

rjmccall commented Aug 1, 2016

Okay, just the same failure about xctest.

@swift-ci Please test.

@rjmccall

This comment has been minimized.

Show comment
Hide comment
@rjmccall

rjmccall Aug 1, 2016

Member

That's a real failure, and a suggestive one. The new diagnostic is forcing a non-public method to be exposed just so the override can be open. We're creating an inconsistency here.

After some discussion with Jordan and Doug, we're going to amend the proposal to lift that half of the "temporary" restriction, so open methods can override non-open ones. This shouldn't be a problem for hierarchy analysis, which has to exhaustively find overrides anyway and can easily recognize when one is open.

Member

rjmccall commented Aug 1, 2016

That's a real failure, and a suggestive one. The new diagnostic is forcing a non-public method to be exposed just so the override can be open. We're creating an inconsistency here.

After some discussion with Jordan and Doug, we're going to amend the proposal to lift that half of the "temporary" restriction, so open methods can override non-open ones. This shouldn't be a problem for hierarchy analysis, which has to exhaustively find overrides anyway and can easily recognize when one is open.

@rjmccall

This comment has been minimized.

Show comment
Hide comment
@rjmccall

rjmccall Aug 1, 2016

Member

So revised.

@swift-ci Please test.

Member

rjmccall commented Aug 1, 2016

So revised.

@swift-ci Please test.

@DougGregor

This comment has been minimized.

Show comment
Hide comment
@DougGregor

DougGregor Aug 2, 2016

Member

The Linux failure is:

fatal error: Attempt to invoke test on class TestNSAffineTransform with incompatible instance type XCTestCase: file /home/buildnode/jenkins/workspace/swift-PR-Linux@3/swift-corelibs-xctest/Sources/XCTest/Public/XCTestCase.swift, line 182

Member

DougGregor commented Aug 2, 2016

The Linux failure is:

fatal error: Attempt to invoke test on class TestNSAffineTransform with incompatible instance type XCTestCase: file /home/buildnode/jenkins/workspace/swift-PR-Linux@3/swift-corelibs-xctest/Sources/XCTest/Public/XCTestCase.swift, line 182

@DougGregor

This comment has been minimized.

Show comment
Hide comment
@DougGregor

DougGregor Aug 2, 2016

Member

@swift-ci please smoke test Linux

Member

DougGregor commented Aug 2, 2016

@swift-ci please smoke test Linux

@rjmccall

This comment has been minimized.

Show comment
Hide comment
@rjmccall

rjmccall Aug 2, 2016

Member

Yeah, I've been looking into it. This might be the first use of required inits; XCTest uses them heavily, and I'm worried we might be devirtualizing it (because it's not open) or something.

Member

rjmccall commented Aug 2, 2016

Yeah, I've been looking into it. This might be the first use of required inits; XCTest uses them heavily, and I'm worried we might be devirtualizing it (because it's not open) or something.

@rjmccall

This comment has been minimized.

Show comment
Hide comment
@rjmccall

rjmccall Aug 2, 2016

Member

Okay, that seemed to fix it. Trying to figure out a test case. In the meantime,

@swift-ci Please test.

Member

rjmccall commented Aug 2, 2016

Okay, that seemed to fix it. Trying to figure out a test case. In the meantime,

@swift-ci Please test.

Implement SE-0117.
One minor revision: this lifts the proposed restriction against
overriding a non-open method with an open one.  On reflection,
that was inconsistent with the existing rule permitting non-public
methods to be overridden with public ones.  The restriction on
subclassing a non-open class with an open class remains, and is
in fact consistent with the existing access rule.
@rjmccall

This comment has been minimized.

Show comment
Hide comment
@rjmccall

rjmccall Aug 2, 2016

Member

That last failure was a new test that hadn't been updated for 'open'.

@swift-ci Please smoke test.

Member

rjmccall commented Aug 2, 2016

That last failure was a new test that hadn't been updated for 'open'.

@swift-ci Please smoke test.

@rjmccall

This comment has been minimized.

Show comment
Hide comment
@rjmccall

rjmccall Aug 2, 2016

Member

I... don't think that's me? I don't know how to interpret that failure.

Member

rjmccall commented Aug 2, 2016

I... don't think that's me? I don't know how to interpret that failure.

@rjmccall

This comment has been minimized.

Show comment
Hide comment
@rjmccall

rjmccall Aug 2, 2016

Member

Weird intermittent failure?

@swift-ci Please smoke test.

Member

rjmccall commented Aug 2, 2016

Weird intermittent failure?

@swift-ci Please smoke test.

@rjmccall rjmccall merged commit 29ccaaf into master Aug 2, 2016

2 checks passed

Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform (smoke test)
Details
@rjmccall

This comment has been minimized.

Show comment
Hide comment
@rjmccall

rjmccall Aug 2, 2016

Member

I should probably have renamed this pull request before actually merging it, huh.

Member

rjmccall commented Aug 2, 2016

I should probably have renamed this pull request before actually merging it, huh.

@rjmccall rjmccall deleted the WIP-SE-0117 branch Aug 2, 2016

@rjmccall rjmccall changed the title from Implement SE-0117 (DON'T MERGE) to Implement SE-0117 Aug 2, 2016

@lattner

This comment has been minimized.

Show comment
Hide comment
@lattner

lattner Aug 2, 2016

Collaborator

LOL. Congrats John!

Collaborator

lattner commented Aug 2, 2016

LOL. Congrats John!

@rjmccall

This comment has been minimized.

Show comment
Hide comment
@rjmccall

rjmccall Aug 2, 2016

Member

:)

Member

rjmccall commented Aug 2, 2016

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment