Importer refactor #4706

Merged
merged 3 commits into from Sep 12, 2016

Projects

None yet

2 participants

@milseman
Contributor
Refactor some 3k lines of code from the class definition (nested 3
indentation levels) to static functions or out-of-line
definitions. Reduces some of code browsing burden of the class, though
I hope to do more cleanup to the file as a whole.

Move helper methods off of the Impl and into CFTypeInfo.h, where we
have the other CF type reasoning logic.

Many of the Impl's methods are relevant to only one file or task. Make
more of them static, and when possible, move them off of the Impl
class.

NFC

Resolves SR-NNNN.

milseman added some commits Sep 10, 2016
@milseman milseman [ClangImporter] Refactor off class methods
Many of the Impl's methods are relevant to only one file or task. Make
more of them static, and when possible, move them off of the Impl
class.

NFC
ffadf05
@milseman milseman [ClangImporter] Refactor off CF reasoning helpers
Move helper methods off of the Impl and into CFTypeInfo.h, where we
have the other CF type reasoning logic.

NFC
b51e0f6
@milseman milseman [ImportDecl] Refactor out in-line code
Refactor some 3k lines of code from the class definition (nested 3
indentation levels) to static functions or out-of-line
definitions. Reduces some of code browsing burden of the class, though
I hope to do more cleanup to the file as a whole.

NFC
1128ce6
@milseman
Contributor

@swift-ci please test

@milseman
Contributor

@swift-ci please smoke test

@milseman
Contributor

@shahmishal any reason why I can't merge this after it passed all tests?

@gottesmm
Member

I am doing the master-next merge so the tree is locked. I sent out an announcement to apple-swift-dev on Friday.

Michael

On Sep 11, 2016, at 10:46 AM, Michael Ilseman notifications@github.com wrote:

@shahmishal https://github.com/shahmishal any reason why I can't merge this after it passed all tests?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub #4706 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AAee3xlr84K3vSmI9aCfbrwFrcgycLCPks5qpD58gaJpZM4J54PO.

@milseman milseman merged commit bf82df6 into apple:master Sep 12, 2016

4 checks passed

Swift Test Linux Platform Build finished.
Details
Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform Build finished. 43230 tests run, 0 skipped, 0 failed.
Details
Swift Test OS X Platform (smoke test)
Details
@milseman milseman deleted the milseman:importer_refactor branch Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment