Fix SR-2242. #4998

Merged
merged 3 commits into from Sep 26, 2016

Projects

None yet

4 participants

@rudkx
Member
rudkx commented Sep 24, 2016

Pull in some refactoring and a fix for SR-2242.

xedin added some commits Sep 23, 2016
@xedin @rudkx xedin [Diagnostics] Refactor argument matching when dealing with a single c…
…andidate

(cherry picked from commit f0078d6)
c57f635
@xedin @rudkx xedin [Diagnostics] Refactor argument source range retrieval
(cherry picked from commit 2dfc8b6)
ca0cc2f
@xedin @rudkx xedin [Diagnostics] SR-2242: Fix diagnostic when argument label is omitted
(cherry picked from commit 054e3e4)
ff8ea2d
@rudkx rudkx added this to the Swift 3.0 milestone Sep 24, 2016
@rudkx rudkx self-assigned this Sep 24, 2016
@rudkx
Member
rudkx commented Sep 24, 2016

@swift-ci Please test OS X.

@rudkx
Member
rudkx commented Sep 24, 2016

@DougGregor Can you review for swift-3.0-branch?

@DougGregor
Member

This looks fantastic!

@tkremenek tkremenek was assigned by rudkx Sep 26, 2016
@tkremenek tkremenek merged commit 33a9744 into apple:swift-3.0-branch Sep 26, 2016

2 checks passed

Swift Test OS X Platform Build finished. 42620 tests run, 0 skipped, 0 failed.
Details
Swift Test OS X Platform (smoke test)
Details
@rudkx rudkx deleted the rudkx:fix-sr-2242-swift-3.0-branch branch Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment