New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix-it to error and add note - SR-4637 #8947

Merged
merged 3 commits into from Apr 30, 2017

Conversation

Projects
None yet
3 participants
@garricn
Contributor

garricn commented Apr 23, 2017

This PR will add a removal fix-it to the ERROR attribute_requires_function_type when the @escaping attribute is applied to a non-function type input parameter.

It will also add the NOTE escaping_optional_type_argument to the same when the parameter is an optional closure.

See: https://twitter.com/garricn/status/854833614487379968

Resolves SR-4637.

@garricn

This comment has been minimized.

Show comment
Hide comment
@garricn

garricn Apr 23, 2017

Contributor

@swift-ci please smoke test

Contributor

garricn commented Apr 23, 2017

@swift-ci please smoke test

@slavapestov

This comment has been minimized.

Show comment
Hide comment
@slavapestov

slavapestov Apr 23, 2017

Member

You need commit access to trigger CI.

@swift-ci Please smoke test

Member

slavapestov commented Apr 23, 2017

You need commit access to trigger CI.

@swift-ci Please smoke test

@garricn

This comment has been minimized.

Show comment
Hide comment
@garricn

garricn Apr 23, 2017

Contributor

@slavapestov Thank you for letting me know. I'll add that to the list of things I learned today :)

Contributor

garricn commented Apr 23, 2017

@slavapestov Thank you for letting me know. I'll add that to the list of things I learned today :)

@garricn

This comment has been minimized.

Show comment
Hide comment
@garricn

garricn Apr 23, 2017

Contributor

Well, looks like I need to take another look tomorrow.

Contributor

garricn commented Apr 23, 2017

Well, looks like I need to take another look tomorrow.

@slavapestov

This comment has been minimized.

Show comment
Hide comment
@slavapestov

slavapestov Apr 23, 2017

Member

You can run tests locally with 'build-script -t', or 'build-script -R -t' to build in release mode, which runs the tests much faster.

Member

slavapestov commented Apr 23, 2017

You can run tests locally with 'build-script -t', or 'build-script -R -t' to build in release mode, which runs the tests much faster.

@garricn

This comment has been minimized.

Show comment
Hide comment
@garricn

garricn Apr 23, 2017

Contributor

Three failures all for the same reason looks like:

Assertion failed: (isValid() && "Can't advance an invalid location"), function getAdvancedLoc, file /Users/PERSONAL/Developer/swift-source/swift/include/swift/Basic/SourceLoc.h, line 51

Must have something to do with my call to SourceRange I assume. I will have to look tomorrow. I am able to run tests with:

./llvm/utils/lit/lit.py -sv ./build/Ninja-RelWithDebInfoAssert/swift-macosx-x86_64/test-macosx-x86_64/ --filter=attr/[NAME OF FILE].swift

I will run all tests locally too.

Thank you!

UPDATE: I realize now that I failed to run all tests locally before pushing PR. My bad.

Contributor

garricn commented Apr 23, 2017

Three failures all for the same reason looks like:

Assertion failed: (isValid() && "Can't advance an invalid location"), function getAdvancedLoc, file /Users/PERSONAL/Developer/swift-source/swift/include/swift/Basic/SourceLoc.h, line 51

Must have something to do with my call to SourceRange I assume. I will have to look tomorrow. I am able to run tests with:

./llvm/utils/lit/lit.py -sv ./build/Ninja-RelWithDebInfoAssert/swift-macosx-x86_64/test-macosx-x86_64/ --filter=attr/[NAME OF FILE].swift

I will run all tests locally too.

Thank you!

UPDATE: I realize now that I failed to run all tests locally before pushing PR. My bad.

@CodaFi

This comment has been minimized.

Show comment
Hide comment
@CodaFi

CodaFi Apr 30, 2017

Collaborator

@swift-ci please smoke test

Collaborator

CodaFi commented Apr 30, 2017

@swift-ci please smoke test

@CodaFi

This comment has been minimized.

Show comment
Hide comment
@CodaFi

CodaFi Apr 30, 2017

Collaborator

Success!

Thanks @garricn, and welcome to the project.

⛵️

Collaborator

CodaFi commented Apr 30, 2017

Success!

Thanks @garricn, and welcome to the project.

⛵️

@CodaFi CodaFi merged commit 7863e29 into apple:master Apr 30, 2017

2 checks passed

Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform (smoke test)
Details
@garricn

This comment has been minimized.

Show comment
Hide comment
@garricn

garricn Apr 30, 2017

Contributor

Woohoo! Thank you so much for helping @CodaFi . I could not have done it without you. I learned a lot though. My ability to set my workstation with the Swift project, build it, run it, make changes, test the changes, and maintain my copy of the project has certainly increased, so thank you!

Contributor

garricn commented Apr 30, 2017

Woohoo! Thank you so much for helping @CodaFi . I could not have done it without you. I learned a lot though. My ability to set my workstation with the Swift project, build it, run it, make changes, test the changes, and maintain my copy of the project has certainly increased, so thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment