Add powerpc64le Linux support #979

antonblanchard · 2016-01-14T20:43:20Z

This patch adds powerpc64le Linux support. While the patch also adds
the matching powerpc64 bits, there are endian issues that need to be
sorted out.

The PowerPC LLVM changes for the swift ABI (eg returning three element
non-homogeneous aggregates) are still in the works, but a simple LLVM
fix to allow those aggregates results in swift passing all but 8
test cases.

Note: It would be nice if swift had conditional compilation based on pointer size, a
number of the test cases only care if the target is 32 or 64 bit.

gribozavr · 2016-01-15T00:05:27Z

Is powerpc64 big-endian?

antonblanchard · 2016-01-15T00:08:41Z

Yes, powerpc64 is big endian. We hope to get big endian working, but for now are concentrating on the little endian port (powerpc64le).

gribozavr · 2016-01-15T00:13:15Z

Sign in to view

@@ -919,7 +919,7 @@ static const uintptr_t ObjCReservedBitsMask =
 static const unsigned ObjCReservedLowBits =
  SWIFT_ABI_X86_64_OBJC_NUM_RESERVED_LOW_BITS;

-#elif defined(__arm64__)
+#elif defined(__arm64__) || defined(__powerpc64__)


Is __powerpc64__ defined on BE, LE or both?

It is defined on both BE and LE targets:

$ uname -m ppc64le $ cpp -dM < /dev/null | grep __powerpc64__ #define __powerpc64__ 1

$ uname -m ppc64 $ cpp -dM < /dev/null | grep __powerpc64__ #define __powerpc64__ 1

The comment above this block says that lib/IRGen/SwiftTargetInfo.cpp needs adjustments (you need to add a configurePowerPC function there).

gribozavr · 2016-01-15T00:13:47Z

Sign in to view

@@ -27,7 +27,7 @@ public struct CGFloat {
  /// The native type used to store the CGFloat, which is Float on
  /// 32-bit architectures and Double on 64-bit architectures.
  public typealias NativeType = Float
-#elseif arch(x86_64) || arch(arm64)
+#elseif arch(x86_64) || arch(arm64) || arch(powerpc64) || arch(powerpc64le)


This file is not built on Linux, please revert this part.

gribozavr · 2016-01-15T00:14:26Z

Sign in to view

@@ -244,7 +244,7 @@ public struct ${Self}
  /// byte order if necessary.
  @_transparent public
  init(bigEndian value: ${Self}) {
-#if arch(i386) || arch(x86_64) || arch(arm) || arch(arm64)
+#if arch(i386) || arch(x86_64) || arch(arm) || arch(arm64) || arch(powerpc64) || arch(powerpc64le)


BE needs a different (the opposite!) implementation here and below.

Nice catch, fixing.

gribozavr · 2016-01-15T00:15:04Z

Sign in to view

@@ -462,7 +462,7 @@ - (BOOL)isNSValue__      { return NO; }

 #if defined(__x86_64__)
 static uintptr_t const objectPointerIsObjCBit = 0x4000000000000000ULL;
-#elif defined(__arm64__)
+#elif defined(__arm64__) || defined(__powerpc64__)


This code is not built on Linux, please revert this part.

gribozavr · 2016-01-15T00:16:01Z

Sign in to view

@@ -77,7 +77,7 @@ func isOSAtLeast(major: Int, _ minor: Int, patch: Int = 0) -> Bool {
 func expectTagged(s: NSString, _ expected: Bool) -> NSString {
 #if arch(x86_64)
  let mask: UInt = 0x8000000000000001
-#elseif arch(arm64)
+#elseif arch(arm64) || arch(powerpc64) || arch(powerpc64le)


This file is not built on Linux, please revert this part.

gribozavr · 2016-01-15T00:17:33Z

Sign in to view

@@ -10,6 +10,8 @@ import Swift
 // armv7k: [[OBJC:%objc_object]] = type
 // arm64:  [[OBJC:%objc_object]] = type
 // i386:   [[OBJC:%objc_object]] = type
+// powerpc64: [[OBJC:%objc_object]] = type
+// powerpc64le: [[OBJC:%objc_object]] = type


This is an ObjC-runtime-specific test. Please add // REQUIRES: objc_interop instead and revert the other changes.

gribozavr · 2016-01-15T00:18:04Z

Sign in to view

@@ -8,7 +8,7 @@ public func == (lhs: CGPoint, rhs: CGPoint) -> Bool {
 public struct CGFloat {
 #if arch(i386) || arch(arm)
  public typealias UnderlyingType = Float
-#elseif arch(x86_64) || arch(arm64)
+#elseif arch(x86_64) || arch(arm64) || arch(powerpc64) || arch(powerpc64le)


This file shouldn't be built on Linux, is it actually built?

gribozavr · 2016-01-15T00:20:52Z

Sign in to view

@@ -37,7 +37,7 @@ if #available(iOS 8.0, *) {
      ],
      bytesFromNSData(element.data))
    expectEqual(4, element.bytesPerIndex)
-  #elseif arch(x86_64) || arch(arm64)
+  #elseif arch(x86_64) || arch(arm64) || arch(powerpc64) || arch(powerpc64le)


This file is not built on Linux, please revert this part.

gribozavr · 2016-01-15T00:21:01Z

Sign in to view

@@ -103,7 +103,7 @@ CoreAudioTestSuite.test(
  "AudioBuffer.init(_: UnsafeMutableBufferPointer, numberOfChannels: Int)/trap") {
 #if arch(i386) || arch(arm)
  let overflowingCount = Int.max
-#elseif arch(x86_64) || arch(arm64)
+#elseif arch(x86_64) || arch(arm64) || arch(powerpc64) || arch(powerpc64le)


This file is not built on Linux, please revert this part.

gribozavr · 2016-01-15T00:22:31Z

How far does this patch allows the port to go? Does the standard library build? Does hello world work? Do the tests run?

antonblanchard · 2016-01-15T01:00:55Z

The powerpc64le port builds and runs the test suite with a few failures:

********************
Testing Time: 275.66s
********************
Failing Tests (5):
    Swift :: 1_stdlib/VarArgs.swift
    Swift :: Driver/filelists.swift
    Swift :: IRGen/c_layout.sil
    Swift :: IRGen/type_layout_reference_storage.swift
    Swift :: Parse/BOM.swift

  Expected Passes    : 1698
  Expected Failures  : 67
  Unsupported Tests  : 651
  Unexpected Failures: 5
*** Failed while running tests for swift (check-swift-linux-powerpc64le)

And hello world works:

$ cat hello.swift 
print("Hello, world!")
$ swiftc hello.swift 
$ ./hello 
Hello, world!

gribozavr · 2016-01-15T01:03:45Z

@antonblanchard I'm really impressed!

gribozavr · 2016-01-15T01:04:13Z

Did you try the validation test suite build-script -T?

antonblanchard · 2016-01-15T01:31:28Z

Thanks, that's given me a few more failing tests to sort out:

********************
Testing Time: 1467.18s
********************
Failing Tests (8):
    Swift :: 1_stdlib/VarArgs.swift
    Swift :: Driver/filelists.swift
    Swift :: IRGen/c_layout.sil
    Swift :: IRGen/type_layout_reference_storage.swift
    Swift :: Parse/BOM.swift
    Swift :: stdlib/AtomicInt.swift
    Swift :: stdlib/CollectionType.swift.gyb
    Swift :: stdlib/FloatingPointConversionTraps.swift.gyb

  Expected Passes    : 6961
  Expected Failures  : 79
  Unsupported Tests  : 771
  Unexpected Failures: 8

gribozavr · 2016-01-15T01:33:34Z

Again, very impressed it is just 8 tests in total!

antonblanchard · 2016-01-15T01:41:06Z

Yes, I'm surprised by how clean the port is. Having the compiler written in c++ (vs the target language), and pulling in clang to get the ABI parameter passing rules helps. Other LLVM based languages have required a lot more work.

Big endian still requires work, but we can attack that once the little endian port is solid.

antonblanchard · 2016-01-15T01:43:04Z

I'm not sure of the preferred workflow, but I'm happy to rebase and squash these commits.

gribozavr · 2016-01-15T01:48:42Z

Sign in to view

    self = ${Self}(Builtin.int_bswap_${BuiltinName}(value._value) )
 #else
-    _UnsupportedArchitectureError()


Please keep the unsupported error so that we get a loud error for new architectures. Just add an explicit #elseif arch(powerpc64) for BE (here and below).

gribozavr · 2016-01-15T01:49:23Z

Yes, we prefer rebasing/squashing.

gribozavr · 2016-01-15T05:13:09Z

lib/Basic/LangOptions.cpp

+    break;
+  case llvm::Triple::ArchType::ppc64le:
+    addTargetConfigOption("arch", "powerpc64le");
+    break;


This part needs a test like test/BuildConfigurations/x64LinuxTarget.swift for each supported triple.

Thanks, will add these tests

gribozavr · 2016-01-15T05:14:01Z

@antonblanchard Thank you! Looks good, but I have two more comments.

lattner · 2016-01-15T05:39:13Z

Very cool, thank you for working on adding this!

This patch adds powerpc64le Linux support. While the patch also adds the matching powerpc64 bits, there are endian issues that need to be sorted out. The PowerPC LLVM changes for the swift ABI (eg returning three element non-homogeneous aggregates) are still in the works, but a simple LLVM fix to allow those aggregates results in swift passing all but 8 test cases.

antonblanchard · 2016-01-15T06:56:31Z

I'm wondering if this is correct. We should have access to the three bottom bits as a result of allocations being aligned, but do I need to care about _objectPointerIsObjCBit on powerpc64 Linux? Should it just be defined to 0?

gribozavr · 2016-01-16T01:37:28Z

@antonblanchard The ObjC values should be dynamically dead as far as I understand. If you find they are also statically unused -- feel free to remove them!

gribozavr · 2016-01-16T02:14:43Z

I ran tests on Ubuntu 14.04 x86_64 and OS X, and see no regressions. Merging. Thank you!

Add powerpc64le Linux support

jrose-apple · 2016-01-16T02:26:50Z

Hm. I wonder if we should start allowing this to be customized soon. LLVM targets aren't that quick to build.

antonblanchard · 2016-01-16T07:21:10Z

Thanks for your help @gribozavr!

gribozavr reviewed Jan 15, 2016
View changes

antonblanchard force-pushed the antonblanchard:powerpc64_merge branch Jan 15, 2016

gribozavr reviewed Jan 15, 2016
View changes

antonblanchard force-pushed the antonblanchard:powerpc64_merge branch to b1827d8 Jan 15, 2016

gribozavr added a commit that referenced this pull request Jan 16, 2016

Merge pull request #979 from antonblanchard/powerpc64_merge

5a1f8b2

Add powerpc64le Linux support

gribozavr merged commit 5a1f8b2 into apple:master Jan 16, 2016

apple / swift

Add powerpc64le Linux support #979

Add powerpc64le Linux support #979

antonblanchard commented Jan 14, 2016

gribozavr commented Jan 15, 2016

antonblanchard commented Jan 15, 2016

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

gribozavr commented Jan 15, 2016

antonblanchard commented Jan 15, 2016

gribozavr commented Jan 15, 2016

gribozavr commented Jan 15, 2016

antonblanchard commented Jan 15, 2016

gribozavr commented Jan 15, 2016

antonblanchard commented Jan 15, 2016

antonblanchard commented Jan 15, 2016

This comment has been minimized.

gribozavr commented Jan 15, 2016

This comment has been minimized.

This comment has been minimized.

gribozavr commented Jan 15, 2016

lattner commented Jan 15, 2016

This comment has been minimized.

antonblanchard commented on `stdlib/public/core/Builtin.swift` in `b1827d8` Jan 15, 2016

gribozavr commented Jan 16, 2016

gribozavr commented Jan 16, 2016

This comment has been minimized.

jrose-apple commented on `utils/build-script-impl` in `b1827d8` Jan 16, 2016

antonblanchard commented Jan 16, 2016

apple / swift

Add powerpc64le Linux support #979

Add powerpc64le Linux support #979

Conversation

antonblanchard commented Jan 14, 2016

gribozavr commented Jan 15, 2016

antonblanchard commented Jan 15, 2016

This comment has been minimized.

gribozavr Jan 15, 2016 Collaborator

This comment has been minimized.

antonblanchard Jan 15, 2016 Author Contributor

This comment has been minimized.

gribozavr Jan 15, 2016 Collaborator

This comment has been minimized.

gribozavr Jan 15, 2016 Collaborator

This comment has been minimized.

gribozavr Jan 15, 2016 Collaborator

This comment has been minimized.

antonblanchard Jan 15, 2016 Author Contributor

This comment has been minimized.

gribozavr Jan 15, 2016 Collaborator

This comment has been minimized.

gribozavr Jan 15, 2016 Collaborator

This comment has been minimized.

gribozavr Jan 15, 2016 Collaborator

This comment has been minimized.

gribozavr Jan 15, 2016 Collaborator

This comment has been minimized.

gribozavr Jan 15, 2016 Collaborator

This comment has been minimized.

gribozavr Jan 15, 2016 Collaborator

gribozavr commented Jan 15, 2016

antonblanchard commented Jan 15, 2016

gribozavr commented Jan 15, 2016

gribozavr commented Jan 15, 2016

antonblanchard commented Jan 15, 2016

gribozavr commented Jan 15, 2016

antonblanchard commented Jan 15, 2016

antonblanchard commented Jan 15, 2016

This comment has been minimized.

gribozavr Jan 15, 2016 Collaborator

gribozavr commented Jan 15, 2016

This comment has been minimized.

gribozavr Jan 15, 2016 Collaborator

This comment has been minimized.

antonblanchard Jan 15, 2016 Author Contributor

gribozavr commented Jan 15, 2016

lattner commented Jan 15, 2016

This comment has been minimized.

antonblanchard commented on stdlib/public/core/Builtin.swift in b1827d8 Jan 15, 2016

gribozavr commented Jan 16, 2016

gribozavr commented Jan 16, 2016

This comment has been minimized.

jrose-apple commented on utils/build-script-impl in b1827d8 Jan 16, 2016

antonblanchard commented Jan 16, 2016

gribozavr Jan 15, 2016
Collaborator

antonblanchard Jan 15, 2016
Author Contributor

gribozavr Jan 15, 2016
Collaborator

gribozavr Jan 15, 2016
Collaborator

gribozavr Jan 15, 2016
Collaborator

antonblanchard Jan 15, 2016
Author Contributor

gribozavr Jan 15, 2016
Collaborator

gribozavr Jan 15, 2016
Collaborator

gribozavr Jan 15, 2016
Collaborator

gribozavr Jan 15, 2016
Collaborator

gribozavr Jan 15, 2016
Collaborator

gribozavr Jan 15, 2016
Collaborator

gribozavr Jan 15, 2016
Collaborator

gribozavr Jan 15, 2016
Collaborator

antonblanchard Jan 15, 2016
Author Contributor

antonblanchard commented on `stdlib/public/core/Builtin.swift` in `b1827d8` Jan 15, 2016

jrose-apple commented on `utils/build-script-impl` in `b1827d8` Jan 16, 2016