/ turicreate Public
Python 3.7 macOS Support #2079
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
I believe this is almost all of the changes we need (in this repository) to support Python 3.7. The only other changes that I know will be needed are in
predict(...)on a coremltools model is broken in Python 3. This is being tracked in an issue in the coremltools repository. We'll need to wait for that to get fixed and for a new version to be released.
All non-CoreML related unit tests pass for Python 3.7 on macOS.
This also fixes #1455