Python 3.7 macOS Support #2079
Merged
Python 3.7 macOS Support #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, this is looking great! I can help with the |
TobyRoseman
force-pushed
the
py37-dev
branch
2 times, most recently
from
91b597b
to
4b15ca7
Compare
TobyRoseman
force-pushed
the
py37-dev
branch
2 times, most recently
from
57f46fc
to
aeef399
Compare
nickjong
reviewed
Aug 6, 2019
| del net._children[24] | ||
| net._children[23] = op | ||
| except KeyError: | ||
| # Newer versions of MXNet use string keys |
There was a problem hiding this comment.
Ah, this definitely explains some of the issues we've seen reported here
znation
approved these changes
Aug 7, 2019
src/python/README.rst
Outdated
| @@ -17,7 +17,7 @@ Turi Create supports: | |||
| System Requirements | |||
| ------------------- | |||
|
|
|||
| - Python 2.7, 3.5, or 3.6 | |||
| - Python 2.7, 3.5, 3.6, or 3.7 (macOS only) | |||
There was a problem hiding this comment.
We might want to clarify that Linux is supported on 2.7, 3.5, and 3.6? To me it looks like all of them are macOS only the way it's written.
src/unsupported_python/setup.py
Outdated
| @@ -25,7 +25,7 @@ def run(self): | |||
|
|
|||
| * Linux x86_64 (including WSL on Windows 10). | |||
| * macOS 10.12+ x86_64. | |||
| * Python 2.7, 3.5, or 3.6. | |||
| * Python 2.7, 3.5, 3.6, or 3.7 (macOS only). | |||
nickjong
approved these changes
Aug 7, 2019
* For macOS and Linux, update all necessary dependencies, other than mxnet. * Install MXNet 1.5.0 only for Python 3.7 on AVX2 supported macOS. * Prevent stackoverflow (inifinte recursion) for TC image resize. * Updated panda dtypes. * Don't clobber symlinks in deps/local/include. * Object Detection use new version of MXNet. * Sound Classifier use new version of MXNet. * Update what versions of Python we say we support. * Make clear Python 3.7 is supported on macOS only * Remove unneeded additional depedencies for scenario tests. * Add pyton 3.7 to docker configs. * Add '--docker-python3.7' option to scenario tests. * Make run_cpp_test.py python 3 compatible. * Add logging to error case. * Use ignore_stale_grad and even_split to ignore MXNet warnings surfaced as exceptions. * Minor unit test refactor. * GitLab CI: Add Python 3.7 for macOS. * GitLab CI: commented out another 10.13 jobs. * Fix Travis CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I believe this is almost all of the changes we need (in this repository) to support Python 3.7. The only other changes that I know will be needed are in
.gitlab-ci.yml.Currently calling
predict(...)on a coremltools model is broken in Python 3. This is being tracked in an issue in the coremltools repository. We'll need to wait for that to get fixed and for a new version to be released.All non-CoreML related unit tests pass for Python 3.7 on macOS.
This also fixes #1455