Fix IC/DC annotation on Linux #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 18, 2019 20:37
Rename .mm to .cpp and remove inclusion of Foundation; this file doesn't appear to need ObjC at all, and we don't need to introduce an ObjC compiler dependency on Linux. This fixes the build for any Linux machines that don't have an ObjC compiler toolchain.
znation
requested review from
abhishekpratapa,
shantanuchhabra and
shreyajain17
znation
commented
Nov 21, 2019
| if __platform == "linux" or __platform == "linux2": | ||
| model = _image_feature_extractor._create_feature_extractor("squeezenet_v1.1") | ||
| feature_sframe = model.extract_features(data, image_column, verbose=False, batch_size=64) | ||
| annotation_window.add_image_features(feature_sframe) |
There was a problem hiding this comment.
Note: since this doesn't appear to be implemented on the server side yet, I opened #2716 to add it.
shreyajain17
approved these changes
Nov 21, 2019
znation
pushed a commit
to znation/turicreate
that referenced
this pull request
Nov 22, 2019
Break caused by apple#2715 -- in release mode, the unused variable causes a warning-as-error.
znation
pushed a commit
that referenced
this pull request
Nov 22, 2019
Break caused by #2715 -- in release mode, the unused variable causes a warning-as-error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Removes call to
add_image_features-- looks like this was perhaps prototyped but never made it into master, as the code on the server side does not exist. This fixes #2401.Also in this PR:
linguist-generatedin.gitattributes. This should cause future PRs to ignore/hide code changes in this directory (as well as not counting its contents for language breakdown reported for the repo).