add python codecov #2976
Merged
add python codecov #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
downstream of #2973 |
TobyRoseman
reviewed
Feb 3, 2020
| @@ -18,9 +18,9 @@ WORKSPACE=${SCRIPT_DIR}/.. | |||
|
|
|||
| unset PYTHONPATH | |||
|
|
|||
| cd $WORKSPACE | |||
| cd "$WORKSPACE" | |||
There was a problem hiding this comment.
Is "$WORKSPACE" the same as ${WORKSPACE}?
There was a problem hiding this comment.
No, the quotes are intentional. https://github.com/koalaman/shellcheck/wiki/SC2086
There was a problem hiding this comment.
I suggest you use this tool called shellcheck along with pre-commit.
guihao-liang
requested review from
TobyRoseman
and removed request for
nickjong
TobyRoseman
approved these changes
Feb 5, 2020
scripts/run_python_test.sh
Outdated
| echo $cmd | ||
| cmd="${cmd} ${PYTEST_EXECUTABLE} --cov -v $PYTHONPATH/turicreate/test \ | ||
| --junit-xml=alltests.pytest.xml" | ||
| echo "$cmd" |
There was a problem hiding this comment.
You probably want to remove this echo. Especially since set -x is included at the top of the script.
There was a problem hiding this comment.
That's right! will do.
|
pass internal tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add pytest-cov plugin to generate the report for the test coverage for our python source file. This test coverage doesn't cover C++ implementation code.
Sample output.