New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up some unnecessary files #3012
Conversation
guihao-liang
commented
Feb 20, 2020
- .flake8.log we don't need to track it in our repo.
- black doesn't need to check py38.
- ignore .pre-commit-config.yaml so that one can have their own customized pre-commit config living together with the repo.
intentionally ignore,
flake8 src/python/turicreate --config=tox.ini | wc -l
864 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add instructions for running flake8 to our build document?
Do we want to add flake8
to our development requirements.txt?
tox.ini
Outdated
@@ -1,3 +1,4 @@ | |||
[flake8] | |||
max-line-length = 88 | |||
extend-ignore = E501 | |||
extend-ignore = E501, E203, E501, E266 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to list E501
twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, my oversight.
.gitignore
Outdated
@@ -105,3 +105,6 @@ deps/build | |||
# CCache within Docker | |||
/.docker_ccache/ | |||
/.docker_images/ | |||
|
|||
# Pre-commit stuff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really think this comment is really adding anything. I'd probably prefer just not having a comment here than having this comment. A better comment might be # git hooks
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's better! Will do.
No, this flake8 is only used by pre-commit hooks and also personal use. Currently, there are too many things that we need to fix in order to use flake8. |