Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set 0045 0046 new #3066

Merged
merged 4 commits into from Apr 30, 2020
Merged

set 0045 0046 new #3066

merged 4 commits into from Apr 30, 2020

Conversation

guihao-liang
Copy link
Collaborator

code review purpose for #3065;

basically, it checks whether the dependencies exist or not. Otherwise, CMake will complain about the target "" is not found.

@guihao-liang guihao-liang self-assigned this Mar 24, 2020
cmake/MakeLibrary.cmake Outdated Show resolved Hide resolved
@guihao-liang
Copy link
Collaborator Author

This will be merged once we sign off #3065

@TobyRoseman
Copy link
Collaborator

@guihao-liang - I'm really not understanding the purpose of this change from your description. Also it looks like a lot of the changes here are just formatting changes. If you're making a large number of formatting changes, it would be helpful to reviewers to do those as a separate commit.

@guihao-liang
Copy link
Collaborator Author

@guihao-liang - I'm really not understanding the purpose of this change from your description. Also it looks like a lot of the changes here are just formatting changes. If you're making a large number of formatting changes, it would be helpful to reviewers to do those as a separate commit.

Yeah, I marked those places that need to be reviewed. Well, the title explains, I set cmake policy 0045 0046 from OLD to NEW, which means it will error out when a target doesn't exist.

@guihao-liang
Copy link
Collaborator Author

Passed internal pipeline. Let's merge.

cmake/MakeLibrary.cmake Outdated Show resolved Hide resolved
cmake/MakeLibrary.cmake Outdated Show resolved Hide resolved
Copy link
Collaborator

@hoytak hoytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just rework the formatting mess-ups and looks fine.

@guihao-liang guihao-liang added this to In progress in 6.3 via automation Apr 29, 2020
@guihao-liang guihao-liang added this to the 6.3 milestone Apr 29, 2020
@guihao-liang guihao-liang merged commit c77f6be into apple:master Apr 30, 2020
6.3 automation moved this from In progress to Done Apr 30, 2020
@guihao-liang guihao-liang deleted the 03-23-new-policy branch May 19, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
6.3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants