New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minimal pkg pipeline #3152
Merged
Merged
minimal pkg pipeline #3152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are built as well.
@brtal This is a good place for you to get familiar with our pipelines. Feel free to review. |
hoytak
approved these changes
May 5, 2020
TobyRoseman
requested changes
May 6, 2020
Merged
TobyRoseman
reviewed
May 6, 2020
adding |
TobyRoseman
approved these changes
May 7, 2020
3d31fe1
to
0e50658
Compare
passed internally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The successor of #3151. Sub-pr: #3171.
The minimal build wheel won't have dependencies listed below.
And the minimal pkg will run relevant tests, which are not considered as part of the
toolkits
components.minimal_test=($(grep -L "toolkits" *.py))
The internal runner will run tests on minimal pkg with 2.7 (Linux) and 3.7 (OSX). The reason to do so is that minimal pkg is the subset of full pkg. As long as full pkg succeeds in all platforms we care about, we should be confident minimal pkg will succeed too.
update 07/05/2020
The feature shown below is from #3175. The package produced by this PR doesn't have any prompt for the user to install the full package. That is to say, this PR is now not related to #3175 now.
Update: 01/05/2020
in the minimal package, if you use lazy-import wrapped
tensorflow
,