Adding MLCompute as a training backend for OD #3276

shreyajain17 · 2020-07-27T22:16:52Z

Merge after #3266

CMakeLists.txt

cmake/SetupCompiler.cmake

brtal

do all of these header files really need the guards in them? i suspect some of them are only included in compiled files (.cpp, .m, .mm) that are already only conditionally being compiled.

src/ml/neural_net/CMakeLists.txt

src/ml/neural_net/TCMLComputeObjectDetectorDescriptor.h

src/ml/neural_net/TCMLComputeObjectDetectorDescriptor.m

src/ml/neural_net/mlc_compute_context.hpp

shreyajain17 requested review from TobyRoseman and brtal July 27, 2020 22:17

shreyajain17 changed the title ~~Adding MLCompute as a training backend for OD~~ [DO NOT MERGE] Adding MLCompute as a training backend for OD Jul 27, 2020

shreyajain17 commented Jul 27, 2020

View changes

CMakeLists.txt Show resolved Hide resolved

TobyRoseman approved these changes Jul 28, 2020

View changes

cmake/SetupCompiler.cmake Show resolved Hide resolved

shreyajain17 changed the title ~~[DO NOT MERGE] Adding MLCompute as a training backend for OD~~ Adding MLCompute as a training backend for OD Jul 28, 2020

brtal reviewed Jul 28, 2020

View changes

shreyajain17 force-pushed the add_mlc branch from 70ddd7c to ebc8033 Compare July 28, 2020 22:40

Adding MLCompute compute context to OD

8431999

shreyajain17 force-pushed the add_mlc branch from aace3b3 to 8431999 Compare July 29, 2020 05:39

brtal approved these changes Jul 29, 2020

View changes

shreyajain17 merged commit 6716bbe into apple:master Jul 29, 2020

Adding MLCompute as a training backend for OD #3276

Adding MLCompute as a training backend for OD #3276

shreyajain17 commented Jul 27, 2020 •

edited

brtal left a comment

Adding MLCompute as a training backend for OD #3276

Adding MLCompute as a training backend for OD #3276

Conversation

shreyajain17 commented Jul 27, 2020 • edited

brtal left a comment

Choose a reason for hiding this comment

shreyajain17 commented Jul 27, 2020 •

edited