build still continue even if commands fail

[ayaka209]

======CMD======
set -o pipefail
cd /home/xxx
mkdir backup-drone
cd backup-drone
mysqldump xx -uxx --add-drop-table --create-options | bzip2 -c > runrunfitness.latest.sql.bz2
cp runrunfitness.latest.sql.bz2 runrunfitness.$(date +%Y%m%d%H%M%S).sql.bz2
 ======END======
err: mkdir: cannot create directory ‘backup-drone’: File exists
err: Enter password: mysqldump: Got error: 1045: Access denied for user 'xx'@'localhost' (using password: NO) when trying to connect
 ==========================================
Successfully executed commands to all host.
 ==========================================

build steps should be stopped and returns error.
continued currently

[mavimo]

@ayaka209 same issue here. Our current temporary solution is to prepend each command with if [ $? -ne 0 ]; then exit 1; fi; in order to interrupt command execution if something fail, eg:

 - set -o pipefail
 - if [ $? -ne 0 ]; then exit 1; fi;
 - cd /home/xxx
 - if [ $? -ne 0 ]; then exit 1; fi;
 - mkdir backup-drone
 - if [ $? -ne 0 ]; then exit 1; fi;
 - cd backup-drone
 - if [ $? -ne 0 ]; then exit 1; fi;
 - mysqldump xx -uxx --add-drop-table --create-options | bzip2 -c > runrunfitness.latest.sql.bz2
 - if [ $? -ne 0 ]; then exit 1; fi;
 - cp runrunfitness.latest.sql.bz2 runrunfitness.$(date +%Y%m%d%H%M%S).sql.bz2

if some step fail other commands are not executed and the build will be interrupted.

@appleboy can you consider to accept a PR that will add the if before each command in plugin when the SH file is created if a specific parameter is added?

[appleboy]

@mavimo PR welcome 👍

[appleboy]

@mavimo @ayaka209 I added testing code about how to use script stop flag. See #124

Thanks for @mavimo contributions.