Skip to content

Commit

Permalink
chore(rpc): graceful shutdown for RPC server (#463)
Browse files Browse the repository at this point in the history
graceful shutdown for grpc service.
  • Loading branch information
appleboy committed Feb 4, 2020
1 parent bcd0e70 commit 2113dfc
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 18 deletions.
8 changes: 6 additions & 2 deletions main.go
Expand Up @@ -271,11 +271,15 @@ func main() {

var g errgroup.Group

// Run httpd server
g.Go(func() error {
return gorush.RunHTTPServer(ctx)
}) // Run httpd server
})

g.Go(rpc.RunGRPCServer) // Run gRPC internal server
// Run gRPC internal server
g.Go(func() error {
return rpc.RunGRPCServer(ctx)
})

// check job completely
g.Go(func() error {
Expand Down
39 changes: 23 additions & 16 deletions rpc/server.go
@@ -1,13 +1,14 @@
package rpc

import (
"net"
"context"
"net/http"
"sync"

"github.com/appleboy/gorush/gorush"
"github.com/appleboy/gorush/rpc/proto"
"golang.org/x/sync/errgroup"

"golang.org/x/net/context"
"google.golang.org/grpc"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/reflection"
Expand Down Expand Up @@ -98,28 +99,34 @@ func (s *Server) Send(ctx context.Context, in *proto.NotificationRequest) (*prot
}

// RunGRPCServer run gorush grpc server
func RunGRPCServer() error {
func RunGRPCServer(ctx context.Context) error {
if !gorush.PushConf.GRPC.Enabled {
gorush.LogAccess.Info("gRPC server is disabled.")
return nil
}

lis, err := net.Listen("tcp", ":"+gorush.PushConf.GRPC.Port)
if err != nil {
gorush.LogError.Errorf("failed to listen: %v", err)
return err
}
s := grpc.NewServer()
srv := NewServer()
proto.RegisterGorushServer(s, srv)
proto.RegisterHealthServer(s, srv)
rpcSrv := NewServer()
proto.RegisterGorushServer(s, rpcSrv)
proto.RegisterHealthServer(s, rpcSrv)
// Register reflection service on gRPC server.
reflection.Register(s)
gorush.LogAccess.Debug("gRPC server is running on " + gorush.PushConf.GRPC.Port + " port.")
if err := s.Serve(lis); err != nil {
gorush.LogError.Errorf("failed to serve: %v", err)
return err
gorush.LogAccess.Info("gRPC server is running on " + gorush.PushConf.GRPC.Port + " port.")

srv := &http.Server{
Addr: ":" + gorush.PushConf.GRPC.Port,
Handler: s,
}

return nil
var g errgroup.Group
g.Go(func() error {
select {
case <-ctx.Done():
return srv.Shutdown(ctx)
}
})
g.Go(func() error {
return srv.ListenAndServe()
})
return g.Wait()
}

0 comments on commit 2113dfc

Please sign in to comment.