Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Render Settings, UI controls, parameters exposed #198

Merged
merged 1 commit into from Mar 10, 2019

Conversation

@luisbarrancos
Copy link
Contributor

luisbarrancos commented Mar 3, 2019

  • Added NEtemplates for asBlendNormals, asRaySwitchSurface, asSurfaceLuminance, asBlendNormals, asASCCDL, asMatte (new shaders added in appleseedhq/appleseed#2426) and icons for the same nodes (#185)
  • Added and expose cast indirect controls for delta lights, and reorganize the delta lights appleseed UI sections
  • Reorganize the UI for mesh/geometry attributes, sections for SPPM, and medium priority, and expose bias control.
  • Remove duplicate turbitidy scale from physical sky and clean its UI
  • Add completely new render globals (or render settings), split into the default Maya section, appleseed and now lighting, output and system. Toggle the controls and sections, subsections according to values of parent attributes, and added Maya annotation and status bar messages
  • Added render stamp status bar message referencing the string replacement allowed by default
  • Fix attribute spreadsheet hiding the appleseed keyable attributes (#167)
  • Minor c++ fixes (missing MString header, fixing wrong order in constructor initializer list, and replacing 0 by nullptr where appropriate)
  • Set softmin and softmax in some attributes according to appleseed defaults
Show resolved Hide resolved src/appleseedmaya/typeids.h
Show resolved Hide resolved src/appleseedmaya/extensionattributes.cpp Outdated
Show resolved Hide resolved src/appleseedmaya/extensionattributes.cpp Outdated
Show resolved Hide resolved src/appleseedmaya/exporters/lightexporter.cpp Outdated
Show resolved Hide resolved src/appleseedmaya/extensionattributes.cpp Outdated
Show resolved Hide resolved scripts/appleseedMaya/renderGlobals.py Outdated
Show resolved Hide resolved scripts/appleseedMaya/renderGlobals.py Outdated
Show resolved Hide resolved scripts/appleseedMaya/renderGlobals.py Outdated
Show resolved Hide resolved scripts/AEappleseedBumpControl.mel Outdated
Show resolved Hide resolved scripts/appleseedMaya/renderGlobals.py Outdated
@dictoon

This comment has been minimized.

Copy link
Member

dictoon commented Mar 3, 2019

Thanks!

Some commit titles deserves to be more descriptive, for instance

Add ray bias, minor fixes

actually includes a whole new Render Globals UI.

@luisbarrancos

This comment has been minimized.

Copy link
Contributor Author

luisbarrancos commented Mar 4, 2019

Thanks!

Some commit titles deserves to be more descriptive, for instance

Add ray bias, minor fixes

actually includes a whole new Render Globals UI.

i think i squashed the wrong commit when compacting the commit history but that will be fixed

@dictoon

This comment has been minimized.

Copy link
Member

dictoon commented Mar 5, 2019

This PR will need to be rebased and related commits to be squashed together.

@dictoon

This comment has been minimized.

Copy link
Member

dictoon commented Mar 5, 2019

Please let us know when it's ready for another round of review!

@luisbarrancos

This comment has been minimized.

Copy link
Contributor Author

luisbarrancos commented Mar 6, 2019

Please let us know when it's ready for another round of review!

I think this stage is ready but i would like to add the new attribute spreadsheet section and some other features (WIP). Screenshots sent by mail (too many for the PR)

@luisbarrancos luisbarrancos force-pushed the luisbarrancos:ui_rework branch from fa0e0aa to d1431d8 Mar 10, 2019

@luisbarrancos luisbarrancos marked this pull request as ready for review Mar 10, 2019

@luisbarrancos luisbarrancos force-pushed the luisbarrancos:ui_rework branch 2 times, most recently from 5b31a48 to 3de2fc3 Mar 10, 2019

Add new shaders, new render globals
namely asASCCDL, asBlendNormals, asRaySwitchSurface, asSurfaceLuminance.
Split the render globals in Lighting, Output, System tabs and exposed
some controls to Dirac delta lights.
Minor fixes and cleanups.

@luisbarrancos luisbarrancos force-pushed the luisbarrancos:ui_rework branch from 3de2fc3 to a47b779 Mar 10, 2019

@luisbarrancos luisbarrancos requested a review from dictoon Mar 10, 2019

@dictoon dictoon merged commit 4ba2039 into appleseedhq:master Mar 10, 2019

@dictoon

This comment has been minimized.

Copy link
Member

dictoon commented Mar 10, 2019

Thanks!

@luisbarrancos luisbarrancos deleted the luisbarrancos:ui_rework branch Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.