Plastic BRDF #1216
Merged
Plastic BRDF #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dictoon
requested changes
Jan 17, 2017
| // https://github.com/mitsuba-renderer/mitsuba | ||
| // | ||
|
|
||
| const char* Model = "plastic_bsdf"; |
There was a problem hiding this comment.
That should probably be plastic_brdf.
| const Basis3f& shading_basis(sample.m_shading_basis); | ||
| const Vector3f& n = shading_basis.get_normal(); | ||
| const Vector3f& outgoing = sample.m_outgoing.get_value(); | ||
| const float cos_on = std::min(dot(outgoing, n), 1.0f); |
There was a problem hiding this comment.
Remove redundant namespace qualifier.
| const float alpha = microfacet_alpha_from_roughness(values->m_roughness); | ||
|
|
||
| // Compute the microfacet normal by sampling the MDF. | ||
| Vector3f wo = shading_basis.transform_to_local(outgoing); |
| Vector3f wo = shading_basis.transform_to_local(outgoing); | ||
| sampling_context.split_in_place(4, 1); | ||
| const Vector4f s = sampling_context.next2<Vector4f>(); | ||
| Vector3f m = m_mdf->sample(wo, Vector3f(s[0], s[1], s[2]), alpha, alpha); |
|
|
||
| const float alpha = microfacet_alpha_from_roughness(values->m_roughness); | ||
|
|
||
| float probability = 0.0; |
|
|
||
| float probability = 0.0f; | ||
|
|
||
| if (ScatteringMode::has_glossy(modes)) |
There was a problem hiding this comment.
Add curly braces around multi-line blocks.
| const Vector3f& m) | ||
| { | ||
| float f; | ||
| foundation::fresnel_reflectance_dielectric( |
There was a problem hiding this comment.
Remove redundant namespace qualifiers.
|
Looking pretty good! Just a few minor things to fix and it's good to merge. I like the fact that the internal scattering parameter is a float, not a boolean. |
|
Make sure to update the test scenes as well. |
|
Should be good to merge now. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to Mitsuba's rough plastic.