New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent changes to asMetal node inputs are incompatible with older scenes #355

Closed
Mango-3 opened this Issue Nov 18, 2018 · 7 comments

Comments

4 participants
@Mango-3
Copy link
Member

Mango-3 commented Nov 18, 2018

My guess is the recent elimination of the energy compensation input in asMetal.osl leads to an unidentified socket typeerror when older scenes are loaded and prevents material preview and production rendering. Replacing the old asMetal node in the Node Editor with a new one fixes rendering.

node_error

@Mango-3 Mango-3 added the Bug label Nov 18, 2018

@Mango-3 Mango-3 changed the title Recent changes in asMetal node inputs incompatible with older scenes Recent changes to asMetal node inputs are incompatible with older scenes Nov 18, 2018

@jdent02

This comment has been minimized.

Copy link
Member

jdent02 commented Nov 20, 2018

So is this a blenderseed issue or an appleseed one? Seems the latter.....

@Mango-3

This comment has been minimized.

Copy link
Member

Mango-3 commented Nov 25, 2018

Well it is not strictly a blenderseed issue, more an OSL-shader issue, but one which is tied to the DCC-specific plugin.
How (unused) inputs are exposed depends on the platform specific metadata. In appleseed-Max we don't have this problem because the Energy Compensation input was never exposed to the user, only internally set to fully compensated. In appleseed-Maya the input was also hidden from the user as far as I know.

@dictoon dictoon added this to High Priority in Live Roadmap Dec 5, 2018

@luisbarrancos

This comment has been minimized.

Copy link

luisbarrancos commented Dec 6, 2018

Ok, so the problem was that this parameter was inadvertantly exposed to the user in blenderseed, and the addition of the input_socket = 0 metadata token, that disallows any input connections to this slot, is breaking scenes that actually had input connections to this socket.
The only solution is keep the parameter hidden as it is now, but comment out the blender metadata. token, input_socket. This was not exposed nor used in other DCC plugins.

@jdent02

This comment has been minimized.

Copy link
Member

jdent02 commented Dec 6, 2018

Hi Luis. Just the fact that the connection was exposed is causing the error, it has nothing to do with whether it was hooked up or not

@jdent02 jdent02 moved this from High Priority to In Progress in Live Roadmap Dec 11, 2018

@jdent02

This comment has been minimized.

Copy link
Member

jdent02 commented Dec 12, 2018

#388 fixes this

@dictoon

This comment has been minimized.

Copy link
Member

dictoon commented Dec 13, 2018

#388 fixes this

Does it? I thought it also introduced other backward-compatibility breaking changes.

@jdent02

This comment has been minimized.

Copy link
Member

jdent02 commented Dec 13, 2018

Fixes it in the sense that the render no longer crashes

@jdent02 jdent02 closed this Dec 28, 2018

Live Roadmap automation moved this from In Progress to Done Dec 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment