Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internet Explorer not working at all #9

Closed
luisrafaelinf opened this issue Sep 26, 2017 · 13 comments
Closed

Internet Explorer not working at all #9

luisrafaelinf opened this issue Sep 26, 2017 · 13 comments
Assignees
Labels
Milestone

Comments

@luisrafaelinf
Copy link

Can you test the design with chrome browser and firefox? there are some issues with the style.

LEFT_OVERLAY : i think that is fine!
LEFT_RESPONSIVE : i think that is fine!

LEFT_RESPONSIVE_OVERLAY :
CHROME > no show the hamburguer button.
FIREFOX > always show the hamburguer button.

LEFT_RESPONSIVE_OVERLAY_NO_APP_BAR :
CHROME > no show the top bar (APP BAR).
FIREFOX > always show the top bar (APP BAR).

LEFT_RESPONSIVE_SMALL : don't reduce the width of HEADER component.

LEFT_RESPONSIVE_SMALL_NO_APP_BAR:
CHROME > no show the top bar (APP BAR) and don't reduce the width of HEADER component.
FIREFOX > always show the top bar (APP BAR), don't reduce the width of HEADER component and always show the hamburguer button.

@appreciated
Copy link
Owner

appreciated commented Sep 26, 2017

So I have fixed it, It seems that the polymer component gives Firefix a different DOM that chrome, which leads to some css Selectors being ignored.

But can

you explain what you mean exactly by this?

don't reduce the width of HEADER component.

If you mean this in the demo:
Overflow

This is not a bug but the Users fault. The user should not insert elements that are too big.

Thank you very much for your findings 👍

appreciated added a commit that referenced this issue Sep 26, 2017
 - fixes for issue #9
 - removed padding in small side bar
@appreciated appreciated self-assigned this Sep 26, 2017
@appreciated appreciated added this to the 0.8.8 milestone Sep 26, 2017
@luisrafaelinf
Copy link
Author

This is not a bug but the Users fault. The user should not insert elements that are too big.

Yes, is that. Remember that you addons is for dummy developers :-)
which by the way is a great help and is excellent.

I hope to soon be able to use it and a few changes to my style in the design 🥇

@appreciated
Copy link
Owner

@luisrafaelinf
Copy link
Author

in firefox continue all the details previously measured.

Internet Explorer all is broken (in my work they use IE unfortunately), it seems that polymer is not compatible.

@luisrafaelinf
Copy link
Author

4

Internet Explorer

@appreciated
Copy link
Owner

appreciated commented Sep 26, 2017

Polymer 2 does support IE 11+ I need to take a look at this.

The Component just works fine in IE 11

@appreciated
Copy link
Owner

Have you tried to recompile the Theme and cleaning the Browser cache for FF?

@luisrafaelinf
Copy link
Author

Have you tried to recompile the Theme and cleaning the Browser cache for FF?

Yes, all that.

@appreciated
Copy link
Owner

appreciated commented Sep 26, 2017

If you are interested you can join me in Slack so we can fix this straight (the firefox stuff)😅 The IE 11 Bug will take a little more time I fear.

@appreciated
Copy link
Owner

appreciated commented Sep 27, 2017

Unfortunately I am not able to fix the bug in Internet Explorer 11.

But I added a workaround for it. As a consequence IE 11 is not behaving responsive. But I think this is actually no problem since the devices requiring the responsive behavior will never use IE 11 😉.

@luisrafaelinf
Copy link
Author

then it is only recommended for mobile interfaces?

@appreciated appreciated changed the title Design with Chrome and Firefox browser Internet Explorer not working at all Sep 27, 2017
@appreciated
Copy link
Owner

appreciated commented Sep 27, 2017

You can use it for both, no problem, the drawback of my described solution is that if you decrease the width of a IE11 Window the Menu will never slide in. Only in IE 11.

appreciated added a commit that referenced this issue Sep 27, 2017
 - workarround for issue #9
 - added bower file for easier installment
@appreciated appreciated modified the milestones: 0.8.8, 0.8.9 Sep 27, 2017
@appreciated
Copy link
Owner

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants