Changed reporters to be lazily loaded #27

Merged
merged 1 commit into from Apr 18, 2015

Projects

None yet

2 participants

@robdmoore
Contributor

Fixes #20 and results in a massive performance improvement in Windows

@robdmoore robdmoore Changed reporters to be lazily loaded
Fixes #20 and results in a massive performance improvement in Windows
8010025
@robdmoore
Contributor

I tried this out on my project and it worked great! Huge performance improvement.

If you have a bunch of failures then they will still be slow, but I figure that's the rarer case and could still be addressed in the future. This fixes my immediate problems.

@robdmoore
Contributor

Also, FYI the two approval files in the test project fail on Windows due to line endings differences. Might be worth storing them as binary via gitattributes.

@staxmanade staxmanade merged commit ac450d0 into approvals:master Apr 18, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@staxmanade
Member

Thanks! Clean!

@robdmoore
Contributor

Thanks for the merge!

When do you think this might hit npm?

@staxmanade
Member

Let me know how this version looks.... 0.0.27

@robdmoore robdmoore deleted the robdmoore:fix-windows-perf branch Apr 19, 2015
@robdmoore
Contributor

Works great! thanks so much! :)

@robdmoore robdmoore referenced this pull request in kristofferahl/approvals-server Apr 19, 2015
Closed

Update to approvals@0.0.27 #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment