Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paging to get around directoryObjects.getByIds limit of 1000 #132

Closed
amanohar opened this issue Apr 30, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@amanohar
Copy link
Collaborator

commented Apr 30, 2018

When trying to detailed description of AAD membership groups using API getbyids: https://github.com/microsoftgraph/microsoft-graph-docs/blob/master/api-reference/v1.0/api/directoryobject_getbyids.md if AAD member has more than 1000 group memerships AAD returns:
image

Therefore, guard needs to do page queries to get details of all groups the user belong to. But getbyids does not support query options like $top and $expand and returns error:
image

So in this case guard cannot rely on AAD to do paging and needs to do paging itself to fetch membership group details from AAD.

amanohar added a commit to amanohar/guard that referenced this issue Apr 30, 2018

Add paging to get around directoryObjects.getByIds limit of 1000
When trying to detailed description of AAD membership groups using API getbyids: https://github.com/microsoftgraph/microsoft-graph-docs/blob/master/api-reference/v1.0/api/directoryobject_getbyids.md if AAD member has more than 1000 group memerships

AAD returns:
    "code": "Request_BadRequest",
    "message": "Number of included identifiers cannot exceed '1000'.",

Therefore, guard needs to do page queries to get details of all groups the user belong to. But getbyids does not support query options like $top and $expand and returns error:

    "code": "Request_BadRequest",
    "message": "The following query options are not supported by this request method or cannot be applied to the requested resource: $filter,$expand,$orderby,$count,$inlinecount,$select,$skiptoken,$skip,$top"

So in this case guard cannot rely on AAD to do paging and needs to do paging itself to fetch membership group details from AAD.

Github issue: appscode#132

tamalsaha added a commit that referenced this issue May 4, 2018

Add paging to get around directoryObjects.getByIds limit of 1000 (#133)
* Add paging to get around directoryObjects.getByIds limit of 1000

When trying to detailed description of AAD membership groups using API getbyids: https://github.com/microsoftgraph/microsoft-graph-docs/blob/master/api-reference/v1.0/api/directoryobject_getbyids.md if AAD member has more than 1000 group memerships

AAD returns:
    "code": "Request_BadRequest",
    "message": "Number of included identifiers cannot exceed '1000'.",

Therefore, guard needs to do page queries to get details of all groups the user belong to. But getbyids does not support query options like $top and $expand and returns error:

    "code": "Request_BadRequest",
    "message": "The following query options are not supported by this request method or cannot be applied to the requested resource: $filter,$expand,$orderby,$count,$inlinecount,$select,$skiptoken,$skip,$top"

So in this case guard cannot rely on AAD to do paging and needs to do paging itself to fetch membership group details from AAD.

Github issue: #132

@amanohar amanohar closed this Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.