Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure AAD auth provider is using AAD group's displayName instead of unique objectId for auth #153

Closed
amanohar opened this issue Jun 19, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@amanohar
Copy link
Collaborator

commented Jun 19, 2018

Currently guard updates AAD token of the user with display name of AAD groups the user belongs to. Several AAD groups in an organization can have the same display name. This can cause group claim based auth using Guard webhook to be unreliable.

Code here: https://github.com/appscode/guard/blob/master/auth/providers/azure/graph/graph.go#L212

Fix: Update Guard to use AAD group's unique id/object id objectId (which is guaranteed to be unique) instead of display name which might not be unique.

E.g. here: https://msdn.microsoft.com/en-us/library/azure/ad/graph/api/groups-operations

cc: @tamalsaha

@amanohar amanohar changed the title Azure AAD auth provider using AAD group's displayName instead of unique objectId for auth Azure AAD auth provider is using AAD group's displayName instead of unique objectId for auth Jun 19, 2018

tamalsaha added a commit that referenced this issue Jun 20, 2018

Allow Azure AAD auth provider to use AAD group ids instead of display…
… name for authn/authz (#154)

Allow Azure AAD auth provider to use AAD group ids instead of display name for authentication

This PR will allow Azure AAD auth provider to be set up to use AAD group ids instead of display names for authentication. More details in issue #153
@tamalsaha

This comment has been minimized.

Copy link
Member

commented Jun 20, 2018

@tamalsaha tamalsaha closed this Jun 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.