Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Azure Active Directory in sovereign cloud #208

Closed
karataliu opened this issue Dec 19, 2018 · 0 comments

Comments

@karataliu
Copy link
Contributor

commented Dec 19, 2018

Azure Active Directory has different instances in sovereign clouds:
https://docs.microsoft.com/en-us/azure/active-directory/develop/authentication-national-cloud

And each one has got different endpoint sets, currently the code has hardcoded to the public cloud's endpoint:
https://github.com/appscode/guard/blob/0.3.0/auth/providers/azure/azure.go#L27
https://github.com/appscode/guard/blob/0.3.0/auth/providers/azure/graph/graph.go#L22

Consider introducing a parameter to support different cloud environment for Azure.

tamalsaha added a commit that referenced this issue Feb 4, 2019
tamalsaha added a commit that referenced this issue Feb 4, 2019
Document how to use Azure sovereign cloud instances
xref: #208

Signed-off-by: Tamal Saha <tamal@appscode.com>
tamalsaha added a commit that referenced this issue Feb 4, 2019
Document how to use Azure sovereign cloud instances (#212)
xref: #208

Signed-off-by: Tamal Saha <tamal@appscode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.