Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installer issues #101

Merged
merged 1 commit into from Mar 21, 2018

Conversation

Projects
None yet
3 participants
@tamalsaha
Copy link
Member

commented Mar 20, 2018

Fixes #91

@tamalsaha tamalsaha requested a review from nightfury1204 Mar 20, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Mar 20, 2018

Codecov Report

Merging #101 into master will decrease coverage by 6.2%.
The diff coverage is 14.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   37.95%   31.74%   -6.21%     
==========================================
  Files          22       22              
  Lines         959     1178     +219     
==========================================
+ Hits          364      374      +10     
- Misses        568      777     +209     
  Partials       27       27
Impacted Files Coverage Δ
server/server.go 0% <ø> (ø) ⬆️
server/utils.go 75% <ø> (+9.54%) ⬆️
auth/providers/github/kubectl.go 0% <ø> (ø)
server/handler.go 23.43% <ø> (ø) ⬆️
auth/providers/azure/graph/graph.go 54.23% <ø> (ø)
auth/providers/gitlab/kubectl.go 0% <ø> (ø)
auth/providers/google/kubectl.go 0% <ø> (ø)
auth/providers/ldap/kubectl.go 0% <ø> (ø)
server/recommended.go 20% <ø> (ø) ⬆️
server/serving.go 4.83% <0%> (-11.83%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5071149...b15c05a. Read the comment docs.

@tamalsaha tamalsaha force-pushed the installer branch 3 times, most recently from 9a473f1 to 38eb3dd Mar 20, 2018

return &d
}

func newSecretForTokenAuth(namespace string, data map[string][]byte) runtime.Object {

This comment has been minimized.

Copy link
@nightfury1204

nightfury1204 Mar 21, 2018

Member

shouldn't it be in installer/secret.go

}
}

func newSecretForLDAP(namespace string, data map[string][]byte) runtime.Object {

This comment has been minimized.

Copy link
@nightfury1204

nightfury1204 Mar 21, 2018

Member

shouldn't it be in installer/secret.go

Google google.Options
Azure azure.Options
LDAP ldap.Options
var labels = map[string]string{

This comment has been minimized.

Copy link
@nightfury1204

nightfury1204 Mar 21, 2018

Member

unused variable

@tamalsaha tamalsaha force-pushed the installer branch 4 times, most recently from 8556950 to 1439c88 Mar 21, 2018

@tamalsaha tamalsaha force-pushed the installer branch from 1439c88 to 30f0c3b Mar 21, 2018

@tamalsaha tamalsaha merged commit 2ff0d69 into master Mar 21, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@tamalsaha tamalsaha deleted the installer branch Mar 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.