Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests #103

Merged
merged 15 commits into from Apr 3, 2018

Conversation

Projects
None yet
2 participants
@tamalsaha
Copy link
Member

commented Mar 21, 2018

@tamalsaha tamalsaha requested a review from nightfury1204 Mar 21, 2018

tamalsaha and others added some commits Mar 29, 2018

var _ = Describe("Installer test", func() {

const (
privateRegistryName = "nightfury1204"

This comment has been minimized.

Copy link
@nightfury1204

nightfury1204 Mar 30, 2018

Member

as i don't have permission, i use my docker hub repository

tamalsaha and others added some commits Apr 3, 2018

args = append(args, fmt.Sprintf("--github.base-url=%s", o.BaseUrl))
}
if o.UploadUrl != "" {
args = append(args, fmt.Sprintf("--github.upload-url=%s", o.UploadUrl))

This comment has been minimized.

Copy link
@tamalsaha

tamalsaha Apr 3, 2018

Author Member

Do we need this?

@tamalsaha tamalsaha merged commit d5e5630 into master Apr 3, 2018

0 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
default

@tamalsaha tamalsaha deleted the e2e branch Apr 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.