Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for github #65

Merged
merged 4 commits into from Mar 7, 2018

Conversation

Projects
None yet
2 participants
@nightfury1204
Copy link
Member

commented Feb 22, 2018

No description provided.

@nightfury1204 nightfury1204 requested a review from tamalsaha Feb 22, 2018

@nightfury1204 nightfury1204 force-pushed the github-test branch 4 times, most recently from 710d4da to d34f20b Feb 22, 2018

@nightfury1204 nightfury1204 force-pushed the github-test branch from d34f20b to 6ab0dfb Feb 26, 2018

if !review.Status.Authenticated {
return fmt.Errorf("Expected authenticated ture, got false")
}
if review.Status.User.Username != "nahid" {

This comment has been minimized.

Copy link
@tamalsaha

tamalsaha Mar 6, 2018

Member

Define constants for these values

for _, size := range teamSizes {
// page=1, PerPage=25
// authenticated : true
t.Run("scenario 1", func(t *testing.T) {

This comment has been minimized.

Copy link
@tamalsaha

tamalsaha Mar 6, 2018

Member

Change the test name to "team size: %d"

)

teamSizes := []int{25, 0, 1, 13, 100, 77, 233}

This comment has been minimized.

Copy link
@tamalsaha

tamalsaha Mar 6, 2018

Member

Restructure the test data like https://github.com/kubernetes/kubernetes/pull/54366/files#diff-11ca6bae99dd41cf90ffc5528959802dR175 , so that the actual test code becomes simple

@nightfury1204 nightfury1204 force-pushed the github-test branch 2 times, most recently from f4b4438 to 3ba78c7 Mar 7, 2018

@nightfury1204 nightfury1204 force-pushed the github-test branch from 3ba78c7 to 739bb95 Mar 7, 2018

@tamalsaha tamalsaha merged commit a785a25 into master Mar 7, 2018

@tamalsaha tamalsaha deleted the github-test branch Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.