Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg codebase #82

Merged
merged 9 commits into from Mar 12, 2018

Conversation

Projects
None yet
2 participants
@tamalsaha
Copy link
Member

commented Mar 11, 2018

Fixes #83
Fixes #14

@tamalsaha tamalsaha requested review from sanjid133 and nightfury1204 Mar 11, 2018

@tamalsaha tamalsaha force-pushed the prom branch 4 times, most recently from 9a1fc57 to a8c0e6a Mar 11, 2018

tamalsaha and others added some commits Mar 12, 2018

}
review.Status.User.Username = username
resp.Username = username

//groups contain group-id
groups, err := c.StringSlice(groupsClaim)

This comment has been minimized.

Copy link
@nightfury1204

nightfury1204 Mar 12, 2018

Member

groups claim not required, because we use ms graph client to get user's groups

tamalsaha added some commits Mar 12, 2018

@tamalsaha tamalsaha merged commit 39b8c17 into master Mar 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tamalsaha tamalsaha deleted the prom branch Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.