Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable admission controllers for webhook server #263

Merged
merged 1 commit into from May 5, 2018

Conversation

Projects
None yet
1 participant
@tamalsaha
Copy link
Member

commented May 5, 2018

Since 1.10 release admission options are enabled by default . This was not the case in 1.9 release. Admission plugins seem unnecessary for a webhook server. So, I am disabling it.

If this is left enabled, then RBAC permissions need to be updated accordingly.

- apiGroups:
  - admissionregistration.k8s.io
  resources:
    - mutatingwebhookconfigurations
    - validatingwebhookconfigurations
  verbs: ["get","list"]
Disable admission controllers for webhook server
Since [1.10 release](https://github.com/kubernetes/apiserver/blob/release-1.10/pkg/server/options/recommended.go#L43) admission options are enabled by default . This was not the case in 1.9 release. Admission plugins seem unnecessary for a webhook server. So, I am disabling it.

If this is left enabled, then RBAC permissions need to be updated accordingly.
```
- apiGroups:
  - admissionregistration.k8s.io
  resources:
    - mutatingwebhookconfigurations
    - validatingwebhookconfigurations
  verbs: ["get","list"]
```

@tamalsaha tamalsaha requested a review from hossainemruz May 5, 2018

@tamalsaha tamalsaha merged commit 2c059bc into master May 5, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@tamalsaha tamalsaha deleted the x7 branch May 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.