Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how stats work #106

Closed
tamalsaha opened this issue May 20, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@tamalsaha
Copy link
Member

commented May 20, 2017

  • Stats should be exposed by a ClusterIP type by service named as <ingress-name>-stats. This will ensure that stats are not internet accessible. This is needed, since stats endpoint is not secured by SSL, even though we have a way to set password.

  • Since stats are not internet accessible any more, using secrets should be optional.

  • Give users option to select stats port using ingress.appscode.com/stats.port. This will allow users to use port 1936 for their own services (if they want to).

@tamalsaha tamalsaha added this to the 1.5.6 milestone May 20, 2017

@tamalsaha tamalsaha changed the title Stats secret name should not be required. Change how stats work May 22, 2017

@tamalsaha

This comment has been minimized.

Copy link
Member Author

commented May 24, 2017

ingress.appscode.com/stats: true   => ingress-stats
ingress.appscode.com/stats.secretName: name  => auth for stats endpoint
ingress.appscode.com/stats.port: 1936
ingress.appscode.com/stats.serviceName: <ingress>-stats
@tamalsaha

This comment has been minimized.

Copy link
Member Author

commented May 29, 2017

Our current plan for integrating with Prometheus has hit a limitation with Prometheus operator. I have filed a bug and pr with the Prometheus operator project. coreos/prometheus-operator#387

Let's see what happens there.

@tamalsaha

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2017

I have updated this issue to only change the stats behavior. This task is already complete for 1.5.6 release.

Sending stats to Prometheus using ServiceMonitor is moved back to #13. This part will happen after 1.5.6 release.

@tamalsaha tamalsaha closed this Jun 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.