Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceMonitor endpoint path created with the wrong APISchemaIngress (typo?) #1451

Closed
ttauveron opened this issue Nov 20, 2019 · 0 comments
Closed

Comments

@ttauveron
Copy link
Contributor

Hi!

I am creating a extensions/v1beta1 ingress resource with the kubernetes.io/ingress.class: voyager annotation :

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: test334
  namespace: test-system
  annotations:
    kubernetes.io/ingress.class: voyager
    ingress.appscode.com/stats: 'true'
    ingress.appscode.com/monitoring-agent: 'prometheus.io/coreos-operator'
    ingress.appscode.com/service-monitor-namespace: 'test-system'
spec:
  tls:
    - secretName: tls-certificate-wildcard-test
      hosts:
      - test334.test.io
  rules:
  - host: test334.test.io
    http:
      paths:
      - backend:
          serviceName: my-service2
          servicePort: 80

Then the following ServiceMonitor is automatically created :

apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  labels:
    monitoring.appscode.com/service: voyager-test334-stats.test-system
  name: voyager-test-system-test334
  namespace: test-system
  ownerReferences:
  - apiVersion: v1
    blockOwnerDeletion: true
    kind: Service
    name: voyager-test334-stats
spec:
  endpoints:
  - honorLabels: true
    path: /extension/v1beta1/namespaces/test-system/ingresses/test334/metrics
    port: http
  namespaceSelector:
    matchNames:
    - test-system
  selector:
    matchLabels:
      feature: stats
      origin: voyager
      origin-api-group: extension
      origin-name: test334

The problem is that I get a 404 error in the Prometheus target because of the path : an s is missing in extension/v1beta1

- extension/v1beta1/namespaces/[...]
+ extensions/v1beta1/namespaces/[...]

I don't get this error when I use the voyager.appscode.com/v1beta1 ingress CRD.

I think this might be due to a typo in here :
https://github.com/appscode/voyager/blob/master/apis/voyager/v1beta1/annotations.go#L39

What do you think?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant