Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HorizontalPodAutoscaling for HAProxy pods #242

Closed
julianvmodesto opened this issue Jun 21, 2017 · 8 comments

Comments

Projects
None yet
2 participants
@julianvmodesto
Copy link
Contributor

commented Jun 21, 2017

Currently, we can manually set the number of haproxy replicas with ingress.appscode.com/replicas: "5", but it would be great if we could support HPA using CPU or memory metrics to start.

@tamalsaha tamalsaha added the research label Jun 22, 2017

@julianvmodesto

This comment has been minimized.

Copy link
Contributor Author

commented Jun 23, 2017

Seems that setting up a HPA resource on a specific voyager-<ingressname> works okay, but i'm curious if ingress.appscode.com/replicas: "5" will affect the HPA? It looks like the annotation updates the Deployment (?) and HPA works as expected w/ any other Deployment.

@tamalsaha

This comment has been minimized.

Copy link
Member

commented Jun 23, 2017

Currently, we set the replica size at the time Deployment is created. After that we leave it unchanged. So, HPA should continue to work. I guess the question is should we enforce the replica size? If not, may be we should call it ingress.appscode.com/initial-replicas. Any thoughts?

@julianvmodesto

This comment has been minimized.

Copy link
Contributor Author

commented Jun 23, 2017

Ahh okay I wouldn't expect the controller enforced the replica size. It seems like the current behavior is actually perfect and the number of replicas updates as expected when a HorizontalPodAutoscaler is introduced for a Deployment.

Maybe there should be no change, just an example of setting up HPA?

@tamalsaha

This comment has been minimized.

Copy link
Member

commented Jun 23, 2017

I guess. If you would like to contribute an example, we are happy to add it to the docs.

@julianvmodesto

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2017

Hmm in our Ingress, we have ingress.appscode.com/replicas: "5", but we manually scaled our Voyager pods to 30 with kubectl scale voyager-frontend --replicas=30. After some undetermined, seemingly random time, our Voyager pods scaled back down to 5. I'm investigating, but I'm wondering if you're aware if this might happen by Voyager Operator under some conditions? Again, I'm continuing to investigate if there was a different cause, but curious if Voyager Operator might do this.

@julianvmodesto

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2017

Oh actually, would Voyager Operator update the Deployment with ingress.appscode.com/replicas if Voyager Operator is upgraded?

@tamalsaha

This comment has been minimized.

Copy link
Member

commented Sep 7, 2017

Checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.