Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require spec.providerCredentialSecretName for own provider #366

Closed
tamalsaha opened this issue Aug 10, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@tamalsaha
Copy link
Member

commented Aug 10, 2017

When Voyager is used in AWS, it should be possible to skip the extra secret. User should be able to just use the existing IAM permissions directly (like we do for opening firewall).

Same goes for GCE, etc.

ref: #337

@tamalsaha

This comment has been minimized.

Copy link
Member Author

commented Aug 11, 2017

func (c *Controller) loadProviderCredential() error {
	cred, err := c.KubeClient.CoreV1().Secrets(c.tpr.Namespace).Get(c.tpr.Spec.ProviderCredentialSecretName, metav1.GetOptions{})
	if err != nil {
		return errors.FromErr(err).Err()
	}
	c.acmeClientConfig.ProviderCredentials = cred.Data
	return nil
}

@tamalsaha tamalsaha modified the milestones: 4.0.0, 3.2.0 Sep 11, 2017

tamalsaha added a commit that referenced this issue Sep 24, 2017

Reimplement certificate controller (#506)
Fixes #505
Fixes #370
Fixes #382
Fixes #526 
Fixes #366 
Fixes #393 
Fixes #356

tamalsaha added a commit that referenced this issue Dec 13, 2017

Reimplement certificate controller (#506)
Fixes #505
Fixes #370
Fixes #382
Fixes #526 
Fixes #366 
Fixes #393 
Fixes #356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.