Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

voyager check should check annotations and dump the parsed annotations #367

Closed
tamalsaha opened this issue Aug 10, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@tamalsaha
Copy link
Member

commented Aug 10, 2017

This will help debug cases where annotations are not properly formatted.

var parser = map[string]func() (interface{}, error) {
	"replicas": meta.GetInt,
	"dns-names": meta.GetArray,
}

func (r Ingress) Replicas() int {
	v, _ := parser["replicas"](r.Annotations["replicas"])
	return v.(int)
}

func (r Ingress) IsValid() int {

}

@tamalsaha tamalsaha self-assigned this Aug 10, 2017

@tamalsaha tamalsaha added this to the 3.2.0 milestone Aug 10, 2017

@tamalsaha tamalsaha assigned sadlil and unassigned tamalsaha Aug 14, 2017

@tamalsaha tamalsaha modified the milestones: 4.0.0, 3.2.0 Sep 11, 2017

@tamalsaha tamalsaha modified the milestones: 4.0.0, 4.1.0 Sep 23, 2017

@tamalsaha tamalsaha modified the milestones: 4.1.0, 5.1.0 Nov 24, 2017

@tamalsaha tamalsaha assigned diptadas and unassigned sadlil Feb 7, 2018

@tamalsaha

This comment has been minimized.

Copy link
Member Author

commented Feb 7, 2018

Ingress.IsValid() should also check.

  • Timeout map
  • Various maps in DNS validator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.